tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false
Date Sat, 09 Nov 2019 09:55:41 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905

--- Comment #18 from Michael Osipov <michaelo@apache.org> ---
(In reply to Christopher Schultz from comment #17)
> (In reply to Michael Osipov from comment #15)
> > (In reply to Christopher Schultz from comment #14)
> > > This should all really be replaced by external stylesheets, for a few
> > > reasons:
> > > 
> > > 1. They are trivially changed by administrators instead of hacking Java code
> > > 2. They can be completely blocked, replaced, etc. by a reverse proxy if
> > > desired
> > > 3. They are more compatible with a desire to reduce response entity byte
> > > count
> > > 4. They can be used with a "safe" CSF policies[1]
> > 
> > I agree here, but this is far more work than I do now at the moment.
> 
> Honestly, I see this as easy:
> 
> 1. Move CSS definitions to [whatever.css]
> 1. Change all CSS to <link rel="stylesheet" href="[whatever.css]" />

It is not that easy. TOMCAT_CSS is used in multiple locations. You have to make
sure that they are present for several components.

> > A lot of stuff is hardcoded in Java, buried in static fields.
> > All of our default apps would require a rewrite -- and all of them are optional!
> 
> "Our default apps" = "Tomcat's default apps"?

Correct!

> You gotta start somewhere.

Analysis first, then discuss.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message