tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: [tomcat] branch master updated: Correct the docs for maxConnections
Date Wed, 20 Nov 2019 16:51:29 GMT
On Wed, Nov 20, 2019 at 5:38 PM <markt@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> View the commit online:
>
> https://github.com/apache/tomcat/commit/33e01c97e24e2ccbe1392a2294e77619d8983fdd
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 33e01c9  Correct the docs for maxConnections
> 33e01c9 is described below
>
> commit 33e01c97e24e2ccbe1392a2294e77619d8983fdd
> Author: Mark Thomas <markt@apache.org>
> AuthorDate: Wed Nov 20 16:33:54 2019 +0000
>
>     Correct the docs for maxConnections
>

Although the feature now actually works for NIO2 (it took a while ...), its
default used to be -1 and it didn't cause problems. The default is now 10k
for NIOx and 8*1024 for APR.

I think it would be nice to change this to either:
- Default to 8*1024 for all connectors, as it would remove one line of code
and a convoluted comment in APR
- Default NIOx to -1

Rémy

Mime
View raw message