tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…
Date Fri, 22 Nov 2019 14:03:42 GMT
michael-o commented on a change in pull request #225: BZ 63681: Introduce RealmBase#authenticate(GSSName,
GSSCredential) an…
URL: https://github.com/apache/tomcat/pull/225#discussion_r349609923
 
 

 ##########
 File path: java/org/apache/catalina/Realm.java
 ##########
 @@ -116,6 +118,17 @@ public Principal authenticate(String username, String digest,
     public Principal authenticate(GSSContext gssContext, boolean storeCreds);
 
 
+    /**
+     * Try to authenticate using a {@link GSSName}
+     *
+     * @param gssName The {@link GSSName} of the principal to look up
+     * @param gssCredential The {@link GSSCredential} of the principal, may be
+     *                      {@code null}
+     * @return the associated principal, or {@code null} if there is none
+     */
+    public Principal authenticate(GSSName gssName, GSSCredential gssCredential);
+
 
 Review comment:
   Please look into `org.apache.catalina.realm.RealmBase.authenticate(GSSName, GSSCredential)`
it will properly handle the `null` case. Those who extend `RealmBase` won't see a change.
   
   The purpose has been described in detail here: https://bz.apache.org/bugzilla/show_bug.cgi?id=63681#c0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message