From dev-return-202730-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Sun Oct 20 12:42:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DE1F8180629 for ; Sun, 20 Oct 2019 14:42:36 +0200 (CEST) Received: (qmail 89678 invoked by uid 500); 20 Oct 2019 12:42:35 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 89667 invoked by uid 99); 20 Oct 2019 12:42:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Oct 2019 12:42:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BC4661A31C4 for ; Sun, 20 Oct 2019 12:42:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=christopherschultz-net.20150623.gappssmtp.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uH2oFtZ6HFxA for ; Sun, 20 Oct 2019 12:42:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::c42; helo=mail-yw1-xc42.google.com; envelope-from=chris@christopherschultz.net; receiver= Received: from mail-yw1-xc42.google.com (mail-yw1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 625847DDAC for ; Sun, 20 Oct 2019 12:42:32 +0000 (UTC) Received: by mail-yw1-xc42.google.com with SMTP id m7so3923564ywe.4 for ; Sun, 20 Oct 2019 05:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=christopherschultz-net.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1VRG52N8aNM+a0QHNMDPClVNEFGUNcUvozURrI3xTiQ=; b=AREjhdyFY+I/AiUu+E7UTPJhhn75J56RKcsyLfvdGwMO+PDJFNFQ5/6U4if8h8bfoE /wlFQZhXNatvHK60OEkgnMbtMKl+0xqNL39xx0l8qzR9OFGQrW3A2AuRa0uoivOpYpZA Fv7q3judK4fPKsncUiZQLZyjy15owIr+akEPRc6YUP9yF26V5XPqBnai3DG73/FJLboE CgwFBz+IglzuolNucswWrrPEtunqPVvjOroGCyHqL5coo0GNoCS8vFJHqPEfFhXRV1kw dITEcF/U/BYwyIHsq+v/t78eb/keAGGuylaQ8zLxyyM1Bh89tLcmASntl7WGFQNA+h9C FK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1VRG52N8aNM+a0QHNMDPClVNEFGUNcUvozURrI3xTiQ=; b=Fq/29GbKEZE+i+KEbVh9Q4vF2h2h4KhF+xWAOooi6R5+4HgGPUtzlfJZnNNMCDupEs iOK212/TmjI1CbCf9LC0eYHwu9GVqFE8ZRu+QCs/J5MRuqk4SCALY3nefuDNY7rpMkM+ 4w9aOmH8Pvq7X1LR0tuPbbtiUaA2sATZBDDFwiRBSs4xm2wYtc+a3B9JfHWhkk236cVs 5LDv2wlYTUmDN79/KMBj2CnMu0DUjuPQ9aZ+Exm3E7Q1s7JqwDwTdKpkAHmFQTrUUxqS SUS6eXCLNlnkxgSN5tysPTEV+yQTo42fPgxscfMYEzm1nuww0cqb2HVqKNDOw8iJjN/q fFyQ== X-Gm-Message-State: APjAAAUIwUjNl1WKKFooRqAiboMubm+9KdV0d5W9xq4zlVpEnTH300RI egtcWFzzEsats9L9hlPRu5xWMxtYmtk= X-Google-Smtp-Source: APXvYqz0KzqeUCyUxOVLD5dYenqBwbpKf+1IU49VtK6z6QuHnR0rhx3zmnMAvnrIvbez2sfpRUUS2g== X-Received: by 2002:a81:6d48:: with SMTP id i69mr916964ywc.46.1571575344695; Sun, 20 Oct 2019 05:42:24 -0700 (PDT) Received: from Christophers-MacBook-Pro-2.local (pool-108-48-175-111.washdc.fios.verizon.net. [108.48.175.111]) by smtp.gmail.com with ESMTPSA id x188sm2706344ywb.94.2019.10.20.05.42.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2019 05:42:24 -0700 (PDT) Subject: Re: [tomcat] branch master updated: Minor optimisation - add new line to access log message outside the sync To: dev@tomcat.apache.org References: <157141573351.17314.1602157761082281552@gitbox.apache.org> From: Christopher Schultz Autocrypt: addr=chris@christopherschultz.net; keydata= mQINBE+pgz4BEADd7qAWgqXcNltlB3aow0UneRmNSVjHKgekgs0ZXxG9l50Athksr/3bL/yg bxFB00JcM9W+UxLhKHiMSyzfeBHn9l9wAlLFKs0S91KXTUnRwGFtvgstvGROoqPgTVREklnm yW/KpzOwqSrQ5xHcogaT+XWlXmRbtFypi52Z5HGWlFWWgwx0vKBWHmQayPtCif0v1RDxfdV9 zziodn0TnpfBQsEgf9TDAjkNT8f0ecwTnhSihTDm1W5HCK7Pm5DfUtree1Oh6Ncz2ljlUO0b 3Lai9pX48eZOj7WQXPefkcv2AoUvdELkQKw3klM5YNXbXPf1KAjky+q4DQ1ydD6LkK+9cI3S TeMesTlk/tytOsaN2NH2k87sEpcumbH0AcmPFEnIYUfm4KzWdKlYA6mbV3Pk3tHSuayyJovj h/7Y7BG9p2l7D60r49hzrTPG8VxNkSliNLcSjI3QjYpfhSlqmqXyVKzdzirK1HPr1xfJStig RpLP9nWarZjoXng9N0etGwtH/8roeDPYA8x9ba1KXy/1g/i+RLx2ms+rueCpnFZxU3GZNUSp RfpdUbwCN3Zm1w5Z6SI8X2aSnWWeYzU6HMsV+P4PROnFsgxDeOpyWhyEaaVLXQtOYwcHneHb n56vSG50TkAuHs5kk/3/YDPSsqjsUPOuhKgFMh3iqMTh5DMdSwARAQABtDJDaHJpc3RvcGhl ciBTY2h1bHR6IDxjaHJpc0BjaHJpc3RvcGhlcnNjaHVsdHoubmV0PokCOgQTAQgAJAIbLwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAUCT6mETgIZAQAKCRDzrVyUpn9wflkxD/9IsahRqHTV /hH5nuPqVO692cQqHvPtMPO6lDb4909VN5T1i+1hFr80P0KVDL6EI78lDBJ2TThWI0o5vFdm sRlei59wsgTvkKTph5QwwOWl7OyzUDX3WbKhkNQdGf4I+/g/1s2bHaRoG30ELdL7cwUPCPrW 0KQwBy7Rtr0WbdujKOw9b/UcgyXEOE1wNcorq/E1o5/6BRYIcFQOO4sjHjGcChOpSg5ms4zb s+Xv3gOtLrbmOPRTXdvBxwJA6kkfQFHvI42kXYghTdqhBVPnHYPqUeavRsb+Yz3ghkZhj35i GfaGyXNwFBikCYjzIaj44NOkT1pU50MgIbjSJ+xoHnC20T942kekqp6wzqUM19Pa9ohsEdA1 Sf6/A7RmpZRrxSIY02ZVnGccnVjglnylVcnxrNAZC3ebxCeZPQ09FBR0Uqlsrdt7A3hlEP2F aoMTSa+hYqfWBGB7uZhcJZIsZspxm8J0txeOzYNSFDl7mF134ShRsq6dpSugCdcdeSWKliBz q0U8sIabOFLMxM0hbwkn2RG4OaurJLWXQf+7IhA/J8TizjkbdxLmR2PiTiVtrx484mpWpbF8 po/em0q/reFnL+JtOM6qlJE/Q4B6PfkchhU5vKPfmGw98t9guyw5G8YSR1rR+SOowHg4T/i2 Rezz1idKmoFpPdNFRPlOAC+d67kCDQRPqYM+ARAAzEItVpzvcgZB+faUWi54lJoA8GnVxXEe OQY+7wk/P5i9GtL0UVXC53j2F87BDVXGalKgVjEVdNY3Cyx+dJ2os65gjxd6ZK18zc6N7YZB Z00XNU9nTz5XImZzHn4VmeXYMQrKO/981nCNPlV6CVdgGg9wl1Ij5Sh8SSTb8kWSo1ngx+XX 4yJNUbfSh32yMPVGI7ZcoZLm9gdgTOOnuEkeeGs/lPvYN+1Cv/YtvkPybSOSWSdHxIVU4Iko 6V7IkM1amjdwKfoeg+CLhZsbY7VLAzVtGvaF5z4rtJtCfTfhbYD0wS8afEBcvsew1HdtYDT5 AJqojeZBGDuY7JCgALc3HCy34Zzk+mi1qwvrm5i/CBMuIvjxB2MkzhHQNUD20fzdRcoIgw4J IzbqZLlOpVFehDXzKT/h5vh+Uv7s6Rz5gP5i0Rkcghw00mRBvuN8mpQnLt4hYL22cNh/tk0L Fxda7ZaPehu7ug4E5FEB0Ifm1KV18P7Kpfu8tiSLz7rl++x73o4uv4bk1ZnjO/jFsx0KLGwq VxR276ZIwsV4WpLYvJ5fR0kqqd/TOKXGSEA0eGxWTeb/fNtkYemRVoasB1+rqjh/Rz0p20o8 elkqDhpzzhrMNzEMYkLySu7npWCeWW4Nd6097+OG9BCLO+ndGmAcupdu6WMEj2UlWsQxuCYC PgsAEQEAAYkEPgQYAQgACQUCT6mDPgIbLgIpCRDzrVyUpn9wfsFdIAQZAQgABgUCT6mDPgAK CRAc8Ck/pTykWO6WD/0XlAG4D4GwzzuOfh7DG6cm/I0vmASEJkY5ghStW4GUbYosgS/btyj/ YPWzVh4HWMvuA6YYKCuz/CM3h34dR25XmHqUdOyJOCnMJ3psdv5YsytgnEdvINZALlDdBX3G sfytgS0KnVjAc92LfJOxHAsZf4zE3SU28FMX7jCgeqO3YrvkHsZ8dzzgw3QYT0J3NcYfkflb DPBXBDGrvdUuea/w6F17pctdRdt7jE3JiLFq2F9ehXOSsIwecUlqVYiCRuxblD4cJ6gKMn0y 8zllW4GyIbf/+mNLkpKoMPYnptDvcEojluHtwbkSfF5AwgJbm6pfs9a2vpGBVko+dBXGh4/T 3qNYxeGEAsI0psEJu3EZN9dYv/ZOb69DUJ6SwEKp/L7lU7C8HoLx/MpKtuJO9OS5uuAhdBSi GqfaN9zP2NxPXSwnexVK2exy/h5sUevDsnBEHmyxe5GRSrIilyijLtlYhq2W7G95poxIFZuL Db98R+7VR9Yl9uOZ6kRBJmzp9X2oB8MDHoKe4QEuiRx/5/DNxB8i2QoTWN/BfluTSfVpO5rf jSXlaUuFOnouBrWdmbaBdg+47m4IGEz129Zdf+y+ISexQ6P16ZY1oYxYlbQSaEwk0+TJ4B0C uvMHwPF3SDH2LeRx+mK2OvwnVulvj2+WdW/rIVgwhwbKmBLj40R+Uq4zD/4iRxJ5PF1ynjxR po3Izp/ZrYWrPgtBg0jUZ8DdlAiRHCFGPpccK8RvBWXmtzF4XQsV39aPBqcE3W6IcTnIMrDi 6mnqealpfiUq+4RGNfRFN9wtgViZLy/FRWi76k+vo/Jmp7/K9JblGX48D2JL9FX0w5PXkpE4 abmY1OASQUiwoJ4n1asxwEonSaWeYbI7X5IqdvevGyfYdSn4VEywdrYGtWjsWlZ/DPofPwsI bQXGY6o+wg9lDAk2L2nVTa05XuyOooUPwKLD0WrLOIxLmcbVv/tgJG03/uI4iDitSofTKnpz E+xdpfFIyw1Mb8PO4WJi0gpHmmLUbG8AMLS+8wSDFwIA4TXQFy9suXXzLuuzML+G5h9Mo5D6 q5HsIe59lhdwk7oEPZJ1NWLfLavTENQg5ObS2YT1KaFskFxxgtcU0aBytAxTjkgGRB8UunXl NJeCuTIAUxXw41P93V4Khigc5dEOG1kEDoq0dAlAE7AbL6Vzc/Go+UwivtUil3sXADOyM9PT JjLNnye+2V0ywQncJ1AG6sxICpPKzv8oYP6xwurEuKnF8DAWEHEwT+Fb277Idv1v8uMGvltp coe7olE0O+TRUtMEwtEp4g4m8ym1rJI/yfwXtHkS8QcVBA9LRqcWEna1VPlT1pk3BSq/1xQa F/4OLScBfV2JbF93sN0SLw== Message-ID: Date: Sun, 20 Oct 2019 08:42:23 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <157141573351.17314.1602157761082281552@gitbox.apache.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark, On 10/18/19 12:22, markt@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > markt pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this > push: new b8cc215 Minor optimisation - add new line to access log > message outside the sync b8cc215 is described below Doesn't this perform a string-mutation instead of a stream-append? Or is it more critical to hold the lock for as short a period as possibl e? - -chris > commit b8cc21574938dc8f46b88396de0694e1ce7aa0a7 Author: Mark Thomas > AuthorDate: Fri Oct 18 17:03:47 2019 +0100 > > Minor optimisation - add new line to access log message outside the > sync --- java/org/apache/catalina/valves/AccessLogValve.java | 2 > +- 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/java/org/apache/catalina/valves/AccessLogValve.java > b/java/org/apache/catalina/valves/AccessLogValve.java index > fe2943e..b133e10 100644 --- > a/java/org/apache/catalina/valves/AccessLogValve.java +++ > b/java/org/apache/catalina/valves/AccessLogValve.java @@ -610,10 > +610,10 @@ public class AccessLogValve extends > AbstractAccessLogValve { > > // Log this message try { + > message.write(System.lineSeparator()); synchronized(this) { if > (writer != null) { message.writeTo(writer); - > writer.println(""); if (!buffered) { writer.flush(); } > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl2sVi4ACgkQHPApP6U8 pFiMAA/8ChWuK3QDa2mOrHkVNKxexYiWD/yr3D/wex6w0BNpmKia6UzCs+qhFgwh 0jxbvbUzEUP11BJym2iZNOryLSk++ZCsq3s/e3730a0wn3eqaFaiCHH9xk2sogZ0 IWK1apDnGgB23mbQ5b+sshJinSWw6453X1XJUjnZtkv9Z89wac6cnfHs1WSqcqv4 bsxyZexlcs+bH3EUqxBqxlIGYxQS3GWQPFboWls04yCksBXwzGgT8s0CWJ94nfb8 jDA1ru0VIvJCwsqCY6ICqA9fXSByHfaZguXBbJ7rdMRHzrrSmwd/uei+leyN5Ch9 WhrwNZ1NlBmjvqQs2dhtMzZqhwWK7X4VEyg34KK0JI1Sx8LlajKd0VaD0J3Vz/FH iu2ej/8YMorSIT8l6gVM28Yh8h+Zd+YeVvrZ7MZRZ0iFz+fXqS2EuR3s6oDU+6X+ 7DSgkY1KMHi14t21fn5YZpAXe01OUI/tLUlP0OXzFrLzstscxOy3Bg24Ka1qT17N rzGanNFlZxqtidyDpj+C17l8RACJbm7bBhlAg9+DaiwjkN+BbE0kKkcapjj0u41p ay5mmX81tGG1qz4WfznD03fSI+H0xnVHdlRG5ewAMOceoKybOiVJjfIRh3mxG2rg tqMCET6SvV3qaGja5trfRib6RVh/mTxAVdvHVW0YmRP/a1SY6Gw= =g4kR -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org