From dev-return-202480-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Fri Oct 11 14:08:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 278D8180656 for ; Fri, 11 Oct 2019 16:08:08 +0200 (CEST) Received: (qmail 70067 invoked by uid 500); 11 Oct 2019 14:08:06 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 70056 invoked by uid 99); 11 Oct 2019 14:08:06 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.42) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Oct 2019 14:08:06 +0000 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 9B9325A6D for ; Fri, 11 Oct 2019 14:08:06 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id 206so3135567ybc.8 for ; Fri, 11 Oct 2019 07:08:06 -0700 (PDT) X-Gm-Message-State: APjAAAUo26+rBaOOTD1IjOQ9QqyGWQlnhSeGolgZnAeV8mn+O2bFcS4Q pDW3vBDVoAVyz42ZdND7LMciRfHqxCOY8KoLcG4= X-Google-Smtp-Source: APXvYqx0boJOzfKMZYLDDDR1ShFgTo3Ub0ln5752LOptY/Q7b6vxwowPt9t/8lNJ6aUzGRorHdYWB6a0bVhvHdWPM54= X-Received: by 2002:a25:8551:: with SMTP id f17mr3344684ybn.394.1570802886018; Fri, 11 Oct 2019 07:08:06 -0700 (PDT) MIME-Version: 1.0 References: <157078262202.29028.12535752263430737792@gitbox.apache.org> <9564d273-e1b1-ac37-af38-c2caf3d6503f@apache.org> In-Reply-To: <9564d273-e1b1-ac37-af38-c2caf3d6503f@apache.org> From: =?UTF-8?Q?R=C3=A9my_Maucherat?= Date: Fri, 11 Oct 2019 16:07:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [tomcat] branch BZ-63835/8.5.x created (now 6ff2233) To: Tomcat Developers List Content-Type: multipart/alternative; boundary="0000000000000890020594a30c53" --0000000000000890020594a30c53 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 11, 2019 at 3:46 PM Michael Osipov wrote: > Am 2019-10-11 um 15:10 schrieb R=C3=A9my Maucherat: > > On Fri, Oct 11, 2019 at 1:51 PM Michael Osipov > wrote: > > > >> Am 2019-10-11 um 11:32 schrieb R=C3=A9my Maucherat: > >>> On Fri, Oct 11, 2019 at 10:43 AM Mark Thomas wrote= : > >>> > >>>> On 11/10/2019 09:30, michaelo@apache.org wrote: > >>>>> This is an automated email from the ASF dual-hosted git repository. > >>>>> > >>>>> michaelo pushed a change to branch BZ-63835/8.5.x > >>>> > >>>> New features should be implemented against master and then back-port= ed > >>>> (assuming the community accepts them). > >>>> > >>> > >>> I also (still) prefer either PRs (it allows comments) or in master. > >> > >> This is a first draft, nothing PR worthy. As soon as I see the code > >> working, I will create the PR by then and when approved in general I > >> will add tests and re-request review. So please be patient. > >> > > > > For this use I'd recommend using your own forked repository then. Using= a > > branch for that doesn't work for me, it sends way too many emails that > are > > not actually useful to dev to the dev mailing list. I tried for a while= , > it > > didn't work, sorry :( > > I am not really convinced by this and I will tell you why: > > * Other TLPs have a commits@ for this > * The purpose of branches is exactly to work on something > * Having it in a fork would take the ability away that people instantly > notice my intermediate changes in a canonical location and leave > valuable comments as you did guys. No one will look at my fork as long > as I don't request it. I rather fix an issue early than two weeks later > in the PR. > I disagree with this so I will draft and hold a formal vote on this to clarify the rules regarding the use of private branches. R=C3=A9my --0000000000000890020594a30c53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 11, 2019 at 3:46 PM Michael Osipov <michaelo@apache.org> wrote:
Am 2019-10-11 um 15:10 schrieb R= =C3=A9my Maucherat:
> On Fri, Oct 11, 2019 at 1:51 PM Michael Osipov <michaelo@apache.org> wrote: >
>> Am 2019-10-11 um 11:32 schrieb R=C3=A9my Maucherat:
>>> On Fri, Oct 11, 2019 at 10:43 AM Mark Thomas <markt@apache.org> wrote: >>>
>>>> On 11/10/2019 09:30, michaelo@apache.org wrote:
>>>>> This is an automated email from the ASF dual-hosted gi= t repository.
>>>>>
>>>>> michaelo pushed a change to branch BZ-63835/8.5.x
>>>>
>>>> New features should be implemented against master and then= back-ported
>>>> (assuming the community accepts them).
>>>>
>>>
>>> I also (still) prefer either PRs (it allows comments) or in ma= ster.
>>
>> This is a first draft, nothing PR worthy. As soon as I see the cod= e
>> working, I will create the PR by then and when approved in general= I
>> will add tests and re-request review. So please be patient.
>>
>
> For this use I'd recommend using your own forked repository then. = Using a
> branch for that doesn't work for me, it sends way too many emails = that are
> not actually useful to dev to the dev mailing list. I tried for a whil= e, it
> didn't work, sorry :(

I am not really convinced by this and I will tell you why:

* Other TLPs have a commits@ for this
* The purpose of branches is exactly to work on something
* Having it in a fork would take the ability away that people instantly notice my intermediate changes in a canonical location and leave
valuable comments as you did guys. No one will look at my fork as long
as I don't request it. I rather fix an issue early than two weeks later=
in the PR.

I disagree with this so I wi= ll draft and hold a formal vote on this to clarify the rules regarding the = use of private branches.

R=C3=A9my
<= br>
--0000000000000890020594a30c53--