From dev-return-202867-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Sat Oct 26 09:47:15 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 318A5180663 for ; Sat, 26 Oct 2019 11:46:36 +0200 (CEST) Received: (qmail 22620 invoked by uid 500); 26 Oct 2019 09:46:34 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 22609 invoked by uid 99); 26 Oct 2019 09:46:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Oct 2019 09:46:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C91FBC08D5 for ; Sat, 26 Oct 2019 09:46:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.001 X-Spam-Level: ** X-Spam-Status: No, score=2.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, KAM_BADIPHTTP=2, NUMERIC_HTTP_ADDR=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id eiscFchL6f9j for ; Sat, 26 Oct 2019 09:46:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.208.44; helo=mail-ed1-f44.google.com; envelope-from=behrangsa@gmail.com; receiver= Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id B0E6DBC598 for ; Sat, 26 Oct 2019 09:35:42 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id c4so3863150edl.0 for ; Sat, 26 Oct 2019 02:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=2AD2NbDg35MRKQ9jlvN7bRcMY+TIeKKjnVALZXTeL8I=; b=LadSNY3AzUXHSmmL28Hb0oR3OG8RsbuwgrA+rTD5Y0Sw4PTMxBqfBrGskycGVgw83/ HHTqiuJMYvamoK2pAGaL1Z8aYm/WQtUStEhjUsre7EoPYuwaq9v51ibkgcXBxTpGaqoN +0+59sLhawrkSk/smGVUwVoV0ENGpsqomDPUphuge9qZqhWnZackbHzgNWDtB4JCgPiR sMFmg/r1N//TNKotReQyAlk8fYeQPLlHlov05CRfZUTmh5IUR4TlW7JhbJe5Jg97SDKa vHY5KwJprr9h+Ehpy8TJsfJQ2tA1XPzhyrXONijYOLFo2hiDkHZoRx1EuOKWIyd8IoVE UqxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2AD2NbDg35MRKQ9jlvN7bRcMY+TIeKKjnVALZXTeL8I=; b=SJqVX7iMyfhzEfLE1uxgYiO83gdrJYKhgyhWmCpvDsfWcOsKGKkq0FreFuLz5iE8gM ijfnMf2Q8D1VzfrG7OuzYbUq3YNz/gi4PAadKc5iWm8y+jo6OT5dbjklERzRbHR0NnAI +t76dacWeyx5JbZvdq0sPZk7Efza5EbMNccTsR2Xvps1rS1lYKKSv/j0eBfjzZL//9Sq j4DXXTWmlI0UmpUoneNx1vKneDu99yIa1+b2lb3gsof4yGqOj4HEzF6TPRr4ENk0Hil4 pL6U0rkkDPgpCbCZtqo8ePwx87rjsohw7gT2ufw6IN/2oAoUSQBBbVlAVpkUPoBlspn7 MCZg== X-Gm-Message-State: APjAAAU0yAsfkNlsWvNmxORwBr5fx2tbRjdBnQROW6DfB/Q/X2HXgL6S PnsXsdOvFhdSZderya5eclzLhuBXSG4qqMo/rXHMHOMBMZE= X-Google-Smtp-Source: APXvYqwb26m2e6W0m4tkTdip9B3LLEeTlGiXwRClSIx5FqsFnrmfeF1IdiTnnBA48iU5LXOjZccoIOLKDGPabqh1OLE= X-Received: by 2002:a17:907:2139:: with SMTP id qo25mr7467808ejb.207.1572082535226; Sat, 26 Oct 2019 02:35:35 -0700 (PDT) MIME-Version: 1.0 From: Behrang Saeedzadeh Date: Sat, 26 Oct 2019 20:34:58 +1100 Message-ID: Subject: What's the purpose of this exception? To: dev@tomcat.apache.org Content-Type: multipart/alternative; boundary="00000000000011e6950595ccfdec" --00000000000011e6950595ccfdec Content-Type: text/plain; charset="UTF-8" From Tomcat Embedded Core 9.0.26: @Override protected void doClose() { if (log.isDebugEnabled()) { log.debug("Calling [" + getEndpoint() + "].closeSocket([" + this + "])", new Exception()); } Which will log something like: DEBUG [http-nio-8080-exec-2] org.apache.tomcat.util.net.NioEndpoint Calling [org.apache.tomcat.util.net.NioEndpoint@654c1a54]. closeSocket([org.apache.tomcat.util.net.NioEndpoint$ NioSocketWrapper@39e9d240:org.apache.tomcat.util.net.NioChannel@78019ed5 :java.nio.channels.SocketChannel[connected local=/127.0.0.1:8080 remote=/127.0.0.1:39988]]) java.lang.Exception: null at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.doClose(NioEndpoint.java:1165) [tomcat-embed-core-9.0.26.jar:9.0.26] at org.apache.tomcat.util.net.SocketWrapperBase.close(SocketWrapperBase.java:394) [tomcat-embed-core-9.0.26.jar:9.0.26] at org.apache.tomcat.util.net.NioEndpoint$Poller. cancelledKey(NioEndpoint.java:667) [tomcat-embed-core-9.0.26.jar:9.0.26] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) [tomcat-embed-core-9.0.26.jar:9.0.26] at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-9.0.26.jar:9.0.26] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_212] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_212] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-9.0.26.jar:9.0.26] at java.lang.Thread.run(Thread.java:748) [na:1.8.0_212] To print the stack trace next to the message? Why not only print the stack trace next to the log message using org.apache.commons.lang3.exception.ExceptionUtils.getStackTrace for example? The presence of the `java.lang.Exception: null` in the logs is a bit misleading and confusing. Best regards, Behrang Saeedzadeh blog.behrang.org --00000000000011e6950595ccfdec Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From Tomcat Embedded Core 9.0.26:

@Override
protected void doClose() {
=C2=A0=C2=A0 if (log.isDebugEnab= led()) {
=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 log.debug("Calling [" + getEndpoint() + "].clos= eSocket([" + this + "])", new Exception());
=C2=A0=C2=A0 }
Which will log something like:

DEBUG [http-nio-8080-e= xec-2]
=C2=A0 =C2=A0 org.a= pache.tomcat.util.net.NioE= ndpoint
=C2=A0 =C2=A0 =C2=A0 =C2=A0 Calling [org.apache.tomcat.util.net.NioEndpoint@654c1a54].closeSocket([org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper@39e9d240:org.apache.tomcat.util.net.NioChannel@78019ed5:java.nio.channels.SocketChannel[connected local=3D/127.0.0.1:8080 remote=3D/127.0.0.1:39988= ]])

java.lang.Exception: null
=C2=A0=C2=A0 at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.doClose(NioEndpoint.java:1165) [tomcat-embed-cor= e-9.0.26.jar:9.0.26]
=C2=A0= =C2=A0 at org.apache.tomcat.u= til.net.SocketWrapperBase.= close(SocketWrapperBase.java:3= 94) [tomcat-embed-core-9.0.26.jar:9.0.26]
=C2=A0=C2=A0 at org.apache.tomcat.util.net.NioEndpoint$Poller.cancelle= dKey(NioEndpoint.java:667) [to= mcat-embed-core-9.0.26.jar:9.0= .26]
=C2=A0=C2=A0 at org.a= pache.tomcat.util.net.NioE= ndpoint$SocketProcessor.doRun(= NioEndpoint.java:1592) [tomcat-embed-core-9.0.26.jar:9.0.26]
=C2=A0=C2=A0 at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-9.0.26.jar:= 9.0.26]
=C2=A0=C2=A0 at jav= a.util.concurrent.ThreadPoolEx= ecutor.runWorker(ThreadPoolExe= cutor.java:1149) [na:1.8.0_212]
=C2=A0=C2=A0 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:= 1.8.0_212]
=C2=A0=C2=A0 at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-9.0.26.jar:9.0.26]
=C2=A0=C2=A0 at java.lang.Thread.run(Thre= ad.java:748) [na:1.8.0_212]

To print the stack trace next to the message? Why not only print the=20 stack trace next to the log message using org.apache.commons.lang3.exceptio= n.ExceptionUtils.getStackTrace for example? The presence of the `java.lang.= Exception: null` in the logs is a bit misleading and confusing.

Best regards,
Behrang Saeedzad= eh
<= a href=3D"https://blog.behrang.org" target=3D"_blank">blog.behrang.org<= /font>
--00000000000011e6950595ccfdec--