tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rémy Maucherat <r...@apache.org>
Subject Re: [tomcat] branch BZ-63835/8.5.x created (now 6ff2233)
Date Fri, 11 Oct 2019 14:07:54 GMT
On Fri, Oct 11, 2019 at 3:46 PM Michael Osipov <michaelo@apache.org> wrote:

> Am 2019-10-11 um 15:10 schrieb Rémy Maucherat:
> > On Fri, Oct 11, 2019 at 1:51 PM Michael Osipov <michaelo@apache.org>
> wrote:
> >
> >> Am 2019-10-11 um 11:32 schrieb Rémy Maucherat:
> >>> On Fri, Oct 11, 2019 at 10:43 AM Mark Thomas <markt@apache.org> wrote:
> >>>
> >>>> On 11/10/2019 09:30, michaelo@apache.org wrote:
> >>>>> This is an automated email from the ASF dual-hosted git repository.
> >>>>>
> >>>>> michaelo pushed a change to branch BZ-63835/8.5.x
> >>>>
> >>>> New features should be implemented against master and then back-ported
> >>>> (assuming the community accepts them).
> >>>>
> >>>
> >>> I also (still) prefer either PRs (it allows comments) or in master.
> >>
> >> This is a first draft, nothing PR worthy. As soon as I see the code
> >> working, I will create the PR by then and when approved in general I
> >> will add tests and re-request review. So please be patient.
> >>
> >
> > For this use I'd recommend using your own forked repository then. Using a
> > branch for that doesn't work for me, it sends way too many emails that
> are
> > not actually useful to dev to the dev mailing list. I tried for a while,
> it
> > didn't work, sorry :(
>
> I am not really convinced by this and I will tell you why:
>
> * Other TLPs have a commits@ for this
> * The purpose of branches is exactly to work on something
> * Having it in a fork would take the ability away that people instantly
> notice my intermediate changes in a canonical location and leave
> valuable comments as you did guys. No one will look at my fork as long
> as I don't request it. I rather fix an issue early than two weeks later
> in the PR.
>

I disagree with this so I will draft and hold a formal vote on this to
clarify the rules regarding the use of private branches.

Rémy

Mime
View raw message