tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [tomcat] branch master updated: Add logging
Date Tue, 01 Oct 2019 12:41:42 GMT
On 01/10/2019 13:01, Rémy Maucherat wrote:
> On Tue, Oct 1, 2019 at 1:54 PM <markt@apache.org
> <mailto:markt@apache.org>> wrote:
> 
>     This is an automated email from the ASF dual-hosted git repository.
> 
>     markt pushed a commit to branch master
>     in repository https://gitbox.apache.org/repos/asf/tomcat.git
> 
> 
>     The following commit(s) were added to refs/heads/master by this push:
>          new d8063b3  Add logging
>     d8063b3 is described below
> 
>     commit d8063b35b0a10afa3c8c666c135f13b801071555
>     Author: Mark Thomas <markt@apache.org <mailto:markt@apache.org>>
>     AuthorDate: Tue Oct 1 12:54:00 2019 +0100
> 
>         Add logging
>     ---
>      java/org/apache/tomcat/util/compat/Jre9Compat.java         | 2 ++
>      java/org/apache/tomcat/util/compat/LocalStrings.properties | 2 ++
>      2 files changed, 4 insertions(+)
> 
>     diff --git a/java/org/apache/tomcat/util/compat/Jre9Compat.java
>     b/java/org/apache/tomcat/util/compat/Jre9Compat.java
>     index 193ea5b..8d8af88 100644
>     --- a/java/org/apache/tomcat/util/compat/Jre9Compat.java
>     +++ b/java/org/apache/tomcat/util/compat/Jre9Compat.java
>     @@ -104,8 +104,10 @@ class Jre9Compat extends JreCompat {
> 
>              } catch (ClassNotFoundException e) {
>                  // Must be Java 8
>     +            log.debug("jre9Compat.java8", e);
>              } catch (ReflectiveOperationException |
>     IllegalArgumentException e) {
>                  // Should never happen
>     +            log.error("jre9Compat.unexpected", e);
> 
> 
> sm.getString is missing in both places. (since it's debug, it doesn't
> have to have i18n anyway imo)

Thanks. I'll fix that.

Fair point about debug. If it isn't translated it will use the English
so nothing is lost.

Mark


> 
> Rémy
>  
> 
>              }
> 
>              inaccessibleObjectExceptionClazz = c1;
>     diff --git
>     a/java/org/apache/tomcat/util/compat/LocalStrings.properties
>     b/java/org/apache/tomcat/util/compat/LocalStrings.properties
>     index 7d53957..b385a35 100644
>     --- a/java/org/apache/tomcat/util/compat/LocalStrings.properties
>     +++ b/java/org/apache/tomcat/util/compat/LocalStrings.properties
>     @@ -14,6 +14,8 @@
>      # limitations under the License.
> 
>      jre9Compat.invalidModuleUri=The module URI provided [{0}] could not
>     be converted to a URL for the JarScanner to process
>     +jre9Compat.java8=Class not found so assuming code is running on Java 8
>     +jre9Compat.unexpected=Failed to create references to Java 9 classes
>     and methods
> 
>      jreCompat.noApplicationProtocol=Java Runtime does not support
>     SSLEngine.getApplicationProtocol(). You must use Java 9 to use this
>     feature.
>      jreCompat.noApplicationProtocols=Java Runtime does not support
>     SSLParameters.setApplicationProtocols(). You must use Java 9 to use
>     this feature.
> 
> 
>     ---------------------------------------------------------------------
>     To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>     <mailto:dev-unsubscribe@tomcat.apache.org>
>     For additional commands, e-mail: dev-help@tomcat.apache.org
>     <mailto:dev-help@tomcat.apache.org>
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message