From dev-return-201570-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Sep 11 10:32:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B96F618063F for ; Wed, 11 Sep 2019 12:32:07 +0200 (CEST) Received: (qmail 80155 invoked by uid 500); 11 Sep 2019 10:32:06 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 80145 invoked by uid 99); 11 Sep 2019 10:32:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 10:32:06 +0000 From: GitBox To: dev@tomcat.apache.org Subject: [GitHub] [tomcat] markt-asf commented on issue #194: fix typo Message-ID: <156819792670.5566.1634483522670564338.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 10:32:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit markt-asf commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530322410 I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR vs multiple PRs doesn't make that much of a difference. What would have helped was re-basing the PR against master. I've done this locally and there were only a couple of conflicts and it makes it much easier to review. I spotted a few unused i18n strings that weren't removed from the translations. That isn't a big deal as the process we use to import/export to/from POEditor will clean those up. I have spotted a couple of minor issues. I'll fix those before merging the commits. I'll also comment on the commit in this PR where it makes sense to do so. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org