tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] xiantang commented on a change in pull request #194: fix typo
Date Wed, 11 Sep 2019 11:45:35 GMT
xiantang commented on a change in pull request #194: fix typo
URL: https://github.com/apache/tomcat/pull/194#discussion_r323195835
 
 

 ##########
 File path: webapps/docs/windows-auth-howto.xml
 ##########
 @@ -101,7 +101,7 @@ policy had to be relaxed. This is not recommended for production environments.
   &lt;service class&gt;/&lt;host&gt;:&lt;port&gt;/&lt;service
name&gt;</code>.
   The SPN used in this how-to is <code>HTTP/win-tc01.dev.local</code>. To
   map the user to the SPN, run the following:
-  <source>setspn -A HTTP/win-tc01.dev.local tc01</source>
+  <source>setspn -An HTTP/win-tc01.dev.local tc01</source>
   </li>
 
 Review comment:
   > I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR
vs multiple PRs doesn't make that much of a difference. What would have helped was re-basing
the PR against master. I've done this locally and there were only a couple of conflicts and
it makes it much easier to review.
   > 
   > I spotted a few unused i18n strings that weren't removed from the translations. That
isn't a big deal as the process we use to import/export to/from POEditor will clean those
up.
   > 
   > I have spotted a couple of minor issues. I'll fix those before merging the commits.
I'll also comment on the commit in this PR where it makes sense to do so.
   
   lol ! It is so hard to review

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message