tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] markt-asf commented on issue #194: fix typo
Date Wed, 11 Sep 2019 10:32:06 GMT
markt-asf commented on issue #194: fix typo
URL: https://github.com/apache/tomcat/pull/194#issuecomment-530322410
 
 
   I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR vs multiple
PRs doesn't make that much of a difference. What would have helped was re-basing the PR against
master. I've done this locally and there were only a couple of conflicts and it makes it much
easier to review.
   
   I spotted a few unused i18n strings that weren't removed from the translations. That isn't
a big deal as the process we use to import/export to/from POEditor will clean those up.
   
   I have spotted a couple of minor issues. I'll fix those before merging the commits. I'll
also comment on the commit in this PR where it makes sense to do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message