From dev-return-200160-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Jul 9 14:38:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4C8118062B for ; Tue, 9 Jul 2019 16:38:48 +0200 (CEST) Received: (qmail 91405 invoked by uid 500); 9 Jul 2019 14:38:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 91390 invoked by uid 99); 9 Jul 2019 14:38:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2019 14:38:47 +0000 From: GitBox To: dev@tomcat.apache.org Subject: [GitHub] [tomcat] michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in RemoteIpValve/RemoteIpFilter Message-ID: <156268312250.21848.3752085229012878142.gitbox@gitbox.apache.org> Date: Tue, 09 Jul 2019 14:38:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in RemoteIpValve/RemoteIpFilter URL: https://github.com/apache/tomcat/pull/178#issuecomment-509669901 * Will fix `changelog.xml` * Indeed, I have blindly copied from `REMOTE_ADDR_ATTRIBUTE`. I can drop `org.apache.coyote.Constants.REQUEST_FORWARDED_ATTRIBUTE` and move the difition to `org.apache.catalina.Globals` directly. Is that what you meant? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org