From dev-return-200088-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Sun Jul 7 18:19:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 20F2918063F for ; Sun, 7 Jul 2019 20:19:45 +0200 (CEST) Received: (qmail 61692 invoked by uid 500); 7 Jul 2019 18:19:43 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 61682 invoked by uid 99); 7 Jul 2019 18:19:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jul 2019 18:19:43 +0000 From: GitBox To: dev@tomcat.apache.org Subject: [GitHub] [tomcat] govi20 edited a comment on issue #177: Code polish: replace classic for-loop with enhanced Message-ID: <156252358365.10020.14240691879135887263.gitbox@gitbox.apache.org> Date: Sun, 07 Jul 2019 18:19:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit govi20 edited a comment on issue #177: Code polish: replace classic for-loop with enhanced URL: https://github.com/apache/tomcat/pull/177#issuecomment-509019980 Yes. `for-loop's` temp variable and `ServletContextAttributeListener's` old var name were clashing. I don't think using `tempListener` in a `for-loop` declaration would be a good idea. `for (Object listener : listeners) ` listener fits here semantically hence I have renamed other variables ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org