tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize
Date Tue, 02 Jul 2019 13:49:59 GMT
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read
in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299493101
 
 

 ##########
 File path: java/org/apache/catalina/connector/CoyoteAdapter.java
 ##########
 @@ -1271,6 +1276,11 @@ public static boolean checkNormalize(MessageBytes uriMB) {
             }
         }
 
+        // The URL must start with '/'
+        if (c[start] != '/') {
+            return false;
+        }
+
         // Check for ending with "/." or "/.."
 
 Review comment:
   I don't see how that can trigger a 500. The request line:
   `GET  %20%2e%2e%20%30%20%0a HTTP/1.1`
   is going to result in a 400 response in all current Tomcat versions.
   Please provide a request line example that triggers the exception in the original report.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message