tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] jchobantonov commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333
Date Wed, 10 Apr 2019 20:35:08 GMT
jchobantonov commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481851585
 
 
   > I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with
`false` value and only set to `true` upon success, or at least after the first block that
calls `LoginContext()` succeeds, instead of repeating it in lines 414, 423, 428, 433, and
437.
   
   It is initialized to true as what we have in DataSourceRealm already - not sure why we
need to initialize it to false - initialize to true means that it is available and when we
detect it is not then we change that to be not available

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message