tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333
Date Wed, 10 Apr 2019 20:33:03 GMT
ChristopherSchultz commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850875
 
 
   > I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with
`false` value and only set to `true` upon success, or at least after the first block that
calls `LoginContext()` succeeds, instead of repeating it in lines 414, 423, 428, 433, and
437.
   
   The availability of the JAAS service might go up and down, so you can't just set it once
and forget about it, of course. To reduce the number of changed lines and opportunities for
mistakes, there could be a local flag for success which is copied to the global flag after
each transaction.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message