tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [tomcat] mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller object.
Date Mon, 08 Apr 2019 14:46:29 GMT
mlem commented on issue #154: Don't serialize the whole valve into session, but use a smaller
object.
URL: https://github.com/apache/tomcat/pull/154#issuecomment-480863047
 
 
   I've filed an issue: https://bz.apache.org/bugzilla/show_bug.cgi?id=63324
   
   The problem is, that we serialize sessions between tomcat instances and the CrawlerSessionManagerValve
has dependencies on unwanted content (like JDK internals)
   
   About the understanding:
   Yes, it doesn't implement serializable, the library we are using is doing it for us. Even
if you don't provide a serializable interface, we can serialize it.
   
   I wanted to write a private inner class accessing your maps directly, but I think, that
the scope of this class would contain the outer class (not so with private static inner classes).
This would bring us the desired effect.
   That's why I'm passing in the maps. They still exist just once in memory, they are not
copies, they are references to the original maps.
   There are some tricks in java 8 to pass in functions to retrieve the correct maps, but
this looks more like a hack than what I did.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message