From dev-return-196464-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Mon Feb 4 16:10:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 086AD180651 for ; Mon, 4 Feb 2019 17:10:12 +0100 (CET) Received: (qmail 85414 invoked by uid 500); 4 Feb 2019 16:10:12 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 85404 invoked by uid 99); 4 Feb 2019 16:10:11 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Feb 2019 16:10:11 +0000 Received: from mail-it1-f170.google.com (mail-it1-f170.google.com [209.85.166.170]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 16FD610F4 for ; Mon, 4 Feb 2019 16:10:11 +0000 (UTC) Received: by mail-it1-f170.google.com with SMTP id g85so976888ita.3 for ; Mon, 04 Feb 2019 08:10:10 -0800 (PST) X-Gm-Message-State: AHQUAuYVeSQHl/78CcTMqVKGZeWam3m2NevBbb7pi6Yt9n6Vww8LYW6h bjKqLRRjaNWOjZO+BSdHlatHIFngYMrCD5bTcjA= X-Google-Smtp-Source: AHgI3IZU/dFRUaMXdpwQXyBP59JJ/9sl7HKXfJVjYbJ1iYoBI05Ku5j7HPfuvEF8haujHcuMcNQ8gVWmeZ1HjygjCs8= X-Received: by 2002:a24:dd8d:: with SMTP id t135mr76325itf.84.1549296610503; Mon, 04 Feb 2019 08:10:10 -0800 (PST) MIME-Version: 1.0 References: <4b9ca656-3ef0-cda9-55e2-1a301768e041@apache.org> <9438c758-34e1-7157-12bc-814833407f58@apache.org> In-Reply-To: From: =?UTF-8?Q?R=C3=A9my_Maucherat?= Date: Mon, 4 Feb 2019 17:09:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Jakarta EE - WebSocket TCK (nightly) To: Tomcat Developers List Content-Type: multipart/alternative; boundary="0000000000001ef032058113ba34" --0000000000001ef032058113ba34 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 1, 2019 at 5:14 PM R=C3=A9my Maucherat wrote: > On Fri, Feb 1, 2019 at 4:50 PM Mark Thomas wrote: > >> On 01/02/2019 14:41, R=C3=A9my Maucherat wrote: >> > On Thu, Jan 31, 2019 at 8:09 PM Mark Thomas wrote: >> > >> >> On 31/01/2019 16:31, Mark Thomas wrote: >> >>> On 31/01/2019 15:58, R=C3=A9my Maucherat wrote: >> >>>> On Wed, Jan 30, 2019 at 8:37 PM Mark Thomas >> wrote: >> >> >> >> >> >>>> I had four issues then that appear to be fixed (three fixes and one >> test >> >>>> gone, which was >> >>>> com.sun.ts.tests.websocket.ee >> >> .javax.websocket.handshakeresponse.getHeadersHasOriginTest). >> >>>> com/sun/ts/tests/websocket/ee/javax/websocket/session/setTimeout1Te= st >> >>>> doesn't pass for me at the moment, although you put in your wiki it >> is >> >>>> fixed. >> >>> >> >>> I'm not 100% sure on that. It might be intermittent. Once I'd been >> >>> through everything once, I was going to do a full run and see where >> >>> things stand. >> >> >> >> Got to the bottom of that one (and 2 others). It was related to how >> >> quickly we checked for session timeout. The default is every 10s whic= h >> >> isn't fast enough for those tests. I've added a system property to >> >> reduce it to every second and that fixes them. >> >> >> > >> > Hum, right, I think I remember that one now. It was a while ago. >> >> Maybe not. Those two are failing consistently for me now. >> > > Will have to look at it again then. > Ok, I think I was completely ignoring the Tomcat client back then, instead using Tyrus, to avoid mixing client and server issues together. So after investigating, it looks like a race condition on the session being in the process of being closed and a message being received by the client concurrently. I put a proposal in the wiki (all tests pass with it). R=C3=A9my --0000000000001ef032058113ba34--