From dev-return-195948-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Tue Jan 8 20:54:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0724F180652 for ; Tue, 8 Jan 2019 20:54:07 +0100 (CET) Received: (qmail 51980 invoked by uid 500); 8 Jan 2019 19:54:02 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 51970 invoked by uid 99); 8 Jan 2019 19:54:02 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2019 19:54:02 +0000 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 5608043B7 for ; Tue, 8 Jan 2019 19:54:01 +0000 (UTC) Received: by mail-qt1-f171.google.com with SMTP id r14so5810557qtp.1 for ; Tue, 08 Jan 2019 11:54:01 -0800 (PST) X-Gm-Message-State: AJcUukdKnCRfQaicxG2NwXG7IVTtzS4of9fMr34UU27Hn9fkzH0MgXBY KGATPwavhfJ/OrYkceJZa+IKZxNhzodmK8MvwftILg== X-Google-Smtp-Source: ALg8bN5lFHFtQWKWr/Q8fbS2GDAdXb8LEPZKENyLw88tiSoc5Z4GILFpYMYVnmtT8wm02Uct3IThTFOvv0wRhN8PfQQ= X-Received: by 2002:ac8:3d91:: with SMTP id v17mr2928976qtf.204.1546977241077; Tue, 08 Jan 2019 11:54:01 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Coty Sutherland Date: Tue, 8 Jan 2019 14:53:50 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: tomcat-native include directory name To: Tomcat Developers List Content-Type: multipart/alternative; boundary="000000000000ee48b8057ef7b4b9" --000000000000ee48b8057ef7b4b9 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas wrote: > On 20/12/2018 19:51, Coty Sutherland wrote: > > Hi all, > > > > Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the > > include directory instead of tomcat-native? I just pushed > > http://svn.apache.org/r1849428 so that make now copies the header files > > into _includedir, and noticed that the directory is named 'apr' rather > than > > 'tomcat-native'. > > If I had to guess, I'd say because the original file was copied from APR > and that part was never changed. > Should fixing that be considered a breaking change and therefore trigger a minor update instead of a revision? Or can I just change it and move on with life? :) > > Mark > > > > > > $ grep includedir native/config.layout > > includedir: ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION} > > includedir: ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION} > > includedir: ${prefix}/include > > includedir: ${prefix}/include+ > > includedir: > > /System/Library/Frameworks/apr.framework/Versions/2.0/Headers > > includedir: ${prefix}/include+ > > includedir: ${prefix}/include/apr > > includedir: ${prefix}/include > > includedir: ${prefix}/include > > includedir: ${prefix}/include/apr > > includedir: ${exec_prefix}/include/apr > > includedir: ${exec_prefix}/include > > includedir: ${exec_prefix}/lib/apr/include > > includedir: ${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION} > > > > > > > > Thanks, > > Coty > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > --000000000000ee48b8057ef7b4b9--