tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Coty Sutherland <csuth...@apache.org>
Subject Re: tomcat-native include directory name
Date Tue, 08 Jan 2019 19:53:50 GMT
On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas <markt@apache.org> wrote:

> On 20/12/2018 19:51, Coty Sutherland wrote:
> > Hi all,
> >
> > Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> > include directory instead of tomcat-native? I just pushed
> > http://svn.apache.org/r1849428 so that make now copies the header files
> > into _includedir, and noticed that the directory is named 'apr' rather
> than
> > 'tomcat-native'.
>
> If I had to guess, I'd say because the original file was copied from APR
> and that part was never changed.
>

Should fixing that be considered a breaking change and therefore trigger a
minor update instead of a revision? Or can I just change it and move on
with life? :)


>
> Mark
>
>
> >
> > $ grep includedir native/config.layout
> >     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >     includedir:    ${prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include+
> >     includedir:
> > /System/Library/Frameworks/apr.framework/Versions/2.0/Headers
> >     includedir:    ${prefix}/include+
> >     includedir:    ${prefix}/include/apr
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include
> >     includedir:    ${prefix}/include/apr
> >     includedir:    ${exec_prefix}/include/apr
> >     includedir:    ${exec_prefix}/include
> >     includedir:    ${exec_prefix}/lib/apr/include
> >     includedir:    ${exec_prefix}/include/apr-${TCNATIVE_MAJOR_VERSION}
> >
> >
> >
> > Thanks,
> > Coty
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message