tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Coty Sutherland <csuth...@redhat.com>
Subject Re: tomcat-native include directory name
Date Thu, 10 Jan 2019 17:50:40 GMT
On Tue, Jan 8, 2019 at 7:06 PM Mark Thomas <markt@apache.org> wrote:

> On 08/01/2019 19:53, Coty Sutherland wrote:
> > On Sun, Dec 23, 2018 at 4:57 AM Mark Thomas <markt@apache.org> wrote:
> >
> >> On 20/12/2018 19:51, Coty Sutherland wrote:
> >>> Hi all,
> >>>
> >>> Is there some reason why we use apr-${TCNATIVE_MAJOR_VERSION} as the
> >>> include directory instead of tomcat-native? I just pushed
> >>> http://svn.apache.org/r1849428 so that make now copies the header
> files
> >>> into _includedir, and noticed that the directory is named 'apr' rather
> >> than
> >>> 'tomcat-native'.
> >>
> >> If I had to guess, I'd say because the original file was copied from APR
> >> and that part was never changed.
> >>
> >
> > Should fixing that be considered a breaking change and therefore trigger
> a
> > minor update instead of a revision? Or can I just change it and move on
> > with life? :)
>
> What could break if you changed this? Isn't it a build time thing rather
> than a run time thing?
>

You're right. I was thinking of this with my package maintainer hat on,
however after checking the package it doesn't depend on that directory
specifically so I think I'm free to correct it.


>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message