tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)
Date Sun, 06 Jan 2019 21:51:42 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Mark,

On 1/6/19 16:37, Mark Thomas wrote:
> On 06/01/2019 17:40, Christopher Schultz wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>> 
>> Woonsan,
>> 
>> On 1/4/19 05:11, Woonsan Ko wrote:
>>> I've noticed in the commit messages that some i18n bundle
>>> files showing Japanese correctly (e.g, 
>>> tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_ja.
pr
>>
>>> 
operties
>>> 
>>> 
>> below) while scrambling it in others (e.g,
>>> tomcat/trunk/java/javax/el/LocalStrings_ja.properties below).
>>> 
>>> The difference comes from whether or not the file was set with
>>> svn property, "svn:mime-type", to "text/plain; charset=UTF-8".
>>> 
>>> $ svn propget svn:mime-type 
>>> java/org/apache/catalina/authenticator/LocalStrings_ja.properties
>>>
>>> 
text/plain; charset=UTF-8 $ svn propget svn:mime-type
>>> java/javax/el/LocalStrings_ja.properties svn: warning:
>>> W200017: Property 'svn:mime-type' not found on 
>>> 'java/javax/el/LocalStrings_ja.properties'
>>> 
>>> Would anyone mind if I set "svn:mime-type" to "text/plain; 
>>> charset=UTF-8" in all the non-English .properties files in
>>> trunk?
> 
> +1. It is an oversight that I haven't been doing this when adding
> new files.
> 
>> - -1
>> 
>> Properties files are, by definition[1], in ISO-8859-1 encoding. 
>> Characters that are not in the ISO-8859-1 character set need to
>> be Unicode-escaped.
>> 
>> For example, if you want ã you need to use \u00e3
>> 
>> I'm not sure why the files haven't been formatted in this way so
>> far.
> 
> Because that is what we decided to do to make the files easier to
> work with: https://tomcat.markmail.org/thread/2fqmyn2ds3vcmfvw

I don't see any invocation of native2ascii in any of the build tools.

Is it an undocumented "feature" of
ResourceBundle/PropertyResourceBundle that UTF-8-encoded files "just
work"?

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwyeG4ACgkQHPApP6U8
pFgOAA//TKw6pHmpTV7+7MDuXe+IzoOV1nLwbWYRLoGmsvsLBA2bhM9fsf6p9vzW
bV7ZOFKpJ/t0t6LmRI2NmWjXwfwFAzOtPastPI/cN9PKQyOGIXofYi4MTU0sb+56
uBwzO8QbuwxhiAkRap/41yI49gf0RbPUELUqCke75z5JvkWVENxgbIAgIsiCjAny
rHoc7nNUWZlJ+xDh5rlP3T65MKKZxtlEAs31QqufCSu5XGx/Gq6PaYEZtWQw7ak9
pB25I2NuStQzUyLKiyqvQhaOYtpf3s8EZYvw8xP9i0RWcoK+aOKvG/Yje2k9oTk8
9N4qUfkqco+P/sSoBjy9cFsf1fIzFL1iGjo1743Ox6StYGqQdNavoE4uxJ+Azgk5
lAYRCj9BCIjeaTnJA4XJsYIROA/NueDyHMdHIaPrS3URdlz9NH+vnOiwwiE3gRcj
V0QBMU5YyLN+d0rB8RLuJ8KLxu9WHJ2x+9j13tTh2pBz9AmTaKUVpC9mF1xVEWDd
pcDCDRWN0o3R9V9vC7lgaK58kjWPlkQPMmKOrsDr+JqrKHgH4E/D3pKVExq31BGD
HJ/dDoJ+Lwcii1d+yyEt55aesAYP4qFP8IRHpztKmdOabTFohjWZrbsj4kI3Y1xV
6MIdpTXb+bhPqi28ZnKQNVKBsJ5RMq+jUq/jBnueua/aywGqYEU=
=tHdX
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message