tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java
Date Fri, 07 Dec 2018 17:53:26 GMT
On 06/12/2018 14:08, Rémy Maucherat wrote:
> On Thu, Dec 6, 2018 at 2:42 PM Mark Thomas <markt@apache.org> wrote:
> 
>>> Ok, why not.
>>
>> Apart from the fact it would mean touching almost every class in Tomcat?
>>
>> Seriously, the more I think about it the more I like it. Move the res
>> package from o.a.tomcat.util.res o.a.juli.res and deprecate the old one
>> along with the copy in tribes. And then remove the old ones in 10.x
>>
> 
> There's another problem with that startup package where the bundles of the
> actual bootstrap are shared with the rest (ContextConfig, etc). Also, is it
> really good to start shipping plenty of resources in a "small" bootstrap ?
> Open questions.

Indeed. I don't think we are under any pressure to find an answer in a
hurry. We can keep discussing until we have a solution that everyone is
happy with.

Should we move the bootstrap classes to a separate package?

That won't address the issues of how to package the resource files for
that package.

Size shouldn't be too much of an issue with the scope limited to just
bootstrap. But if they are all in a single JAR disabling a language by
deleting the JAR won't work for the bootstrap resources. I don't think
per language bootstrap resource JARs are the solution.


>>>>> - the "upstream" strings: dbcp, pool, bcel, fileupload
>>>>
>>>> We could 'fix' them. It would mean the code diverging further from the
>>>> original which will make syncing harder. Roughly how many Strings are we
>>>> talking about here?
>>>>
>>>
>>> About 200.
>>
>> Hmm. DBCP2 already has simple l10n support along the lines of:
>>
>> private static final ResourceBundle messages = ResourceBundle.getBundle(
>>         Utils.class.getPackage().getName() + ".LocalStrings");
>>
>> That could be extended. Every ASF committer has commit access to Commons
>> so I guess it could just be fixed at source. I'll volunteer to merge the
>> changes back into Tomcat.
>>
>> Pool2 doesn't use a ResourceBundle but I don't see why it couldn't. Same
>> for FileUpload.
>>
>> BCEL code is so far removed from Commons BCEL I'd probably just fix it
>> locally.
>>
> 
> Ok. OTOH about DBCP it's surprising there's something because in other
> places you find this kind of code which means nobody cares at all:
> stringBuilder.append(NUPROP_WARNTEXT.get(propertyName)).append(" You have
> set value of \"")
>                             .append(propertyValue).append("\" for
> \"").append(propertyName)
>                             .append("\" property, which is being ignored.");
> 
> For sure fixing this will be done last ;)

Yep.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message