tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1847321 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
Date Fri, 23 Nov 2018 21:34:41 GMT
Author: markt
Date: Fri Nov 23 21:34:41 2018
New Revision: 1847321

URL: http://svn.apache.org/viewvc?rev=1847321&view=rev
Log:
Make code easier to check for correctness

Modified:
    tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java

Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java?rev=1847321&r1=1847320&r2=1847321&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java (original)
+++ tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java Fri Nov 23 21:34:41
2018
@@ -82,9 +82,9 @@ public class JspServletWrapper {
     // Logger
     private final Log log = LogFactory.getLog(JspServletWrapper.class); // must not be static
 
-    private Servlet theServlet;
+    private volatile Servlet theServlet;
     private final String jspUri;
-    private Class<?> tagHandlerClass;
+    private volatile Class<?> tagHandlerClass;
     private final JspCompilationContext ctxt;
     private long available = 0L;
     private final ServletConfig config;
@@ -281,7 +281,6 @@ public class JspServletWrapper {
                 synchronized (this) {
                     if (getReloadInternal() || tagHandlerClass == null) {
                         tagHandlerClass = ctxt.load();
-                        // Volatile 'reload' forces in order write of 'tagHandlerClass'
                         reload = false;
                     }
                 }



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message