From dev-return-193733-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Oct 3 17:52:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B82E18065B for ; Wed, 3 Oct 2018 17:52:35 +0200 (CEST) Received: (qmail 45451 invoked by uid 500); 3 Oct 2018 15:52:34 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 45439 invoked by uid 99); 3 Oct 2018 15:52:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Oct 2018 15:52:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BE0171A03A6 for ; Wed, 3 Oct 2018 15:52:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.652 X-Spam-Level: X-Spam-Status: No, score=0.652 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_NONE=-0.0001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0-FueL-tSgDR for ; Wed, 3 Oct 2018 15:52:32 +0000 (UTC) Received: from smtp121.iad3b.emailsrvr.com (smtp121.iad3b.emailsrvr.com [146.20.161.121]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 41F455F23D for ; Wed, 3 Oct 2018 15:52:32 +0000 (UTC) Received: from smtp8.relay.iad3b.emailsrvr.com (localhost [127.0.0.1]) by smtp8.relay.iad3b.emailsrvr.com (SMTP Server) with ESMTP id C822440091 for ; Wed, 3 Oct 2018 11:52:25 -0400 (EDT) X-Auth-ID: mitch@claborn.net Received: by smtp8.relay.iad3b.emailsrvr.com (Authenticated sender: mitch-AT-claborn.net) with ESMTPSA id 9D54340070 for ; Wed, 3 Oct 2018 11:52:25 -0400 (EDT) X-Sender-Id: mitch@claborn.net Received: from [192.168.45.5] ([UNAVAILABLE]. [63.249.40.11]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:465 (trex/5.7.12); Wed, 03 Oct 2018 11:52:25 -0400 Subject: Re: Bug 62140 implementation question To: dev@tomcat.apache.org References: <509da1ae-8ca5-ddce-7734-65e83e62aea4@redhat.com> <0571f5bf-5e80-982a-f500-3517f37ccbb1@redhat.com> From: Mitch Claborn Message-ID: Date: Wed, 3 Oct 2018 10:52:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0571f5bf-5e80-982a-f500-3517f37ccbb1@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit My only thought was the single-source value. If it would be a lot of extra work to do the text file, then I think the original design is fine. Mitch On 10/02/2018 09:56 AM, Marek Czernek wrote: > Well, I personally would prefer if it was  a soure-able (or call-able > for windows) script; otherwise, you'd have to parse the text file to > check which part of the text you want to output, since you don't want to > output all the text at once, but only for one particular verb. > > Any particular benefits for a text file over two scripts? It's true it's > single-sourced, but given that all scripts are essentially duplicated > into .sh and .bat, I don't feel like that outweighs the ease of use and > extensibility of the help script files. > > On 10/2/18 4:45 PM, Mitch Claborn wrote: >> Are the available verbs the same for both .sh and .bat? If so, perhaps >> a text file that contains the actual help text that could be output >> from both .bat and .sh. >> >> >> Mitch >> >> On 10/01/2018 02:48 PM, Marek Czernek wrote: >>> Hi there, >>> >>> I'd like to resolve Bug 62140 [0]. I just wanted to gather some >>> opinions about the implementation details. In my mind, the following >>> solution is quite reasonable: >>> >>> 1. Create new help scripts, such as help.sh and help.bat. These files >>>     contain a method for each functional verb that prints some info >>>     about the verb and exits with 0. >>> 2. Source the files in both catalina.sh and catalina.bat >>> 3. When user enters catalina.[sh|bat] $verb help (or -h, --help?), >>>     execute one of the methods. >>> >>> In my mind, the above solution is quite straightforward. Any gotchas, >>> or obvious problems? >>> >>> [0] https://bz.apache.org/bugzilla/show_bug.cgi?id=62140 >>> >>> Cheers, >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org >> For additional commands, e-mail: dev-help@tomcat.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org