From dev-return-193688-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Oct 3 00:28:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B017180638 for ; Wed, 3 Oct 2018 00:28:06 +0200 (CEST) Received: (qmail 58751 invoked by uid 500); 2 Oct 2018 22:28:05 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 58741 invoked by uid 99); 2 Oct 2018 22:28:05 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 22:28:05 +0000 Received: from [192.168.1.101] (45-19-167-161.lightspeed.irvnca.sbcglobal.net [45.19.167.161]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id 849B754A9 for ; Tue, 2 Oct 2018 22:28:04 +0000 (UTC) Subject: Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coyote/http2/Http2TestBase.java From: Igal Sapir To: dev@tomcat.apache.org References: <20181002213958.A501A3A004A@svn01-us-west.apache.org> <9fccd9bb-1614-f706-5653-0fce2c45c5cc@kippdata.de> <3d4c22a6-1898-0a57-2fb1-ea42d7650f8f@apache.org> Organization: Apache Software Foundation Message-ID: <07c0d4ef-ca4b-59d8-a0ea-7f0965acd657@apache.org> Date: Tue, 2 Oct 2018 15:28:03 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3d4c22a6-1898-0a57-2fb1-ea42d7650f8f@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Rainer, On 10/2/2018 3:03 PM, Igal Sapir wrote: > Hi Rainer, > > On 10/2/2018 2:54 PM, Rainer Jung wrote: >> Hi Igal, >> >> Am 02.10.2018 um 23:39 schrieb isapir@apache.org: >>> Author: isapir >>> Date: Tue Oct  2 21:39:57 2018 >>> New Revision: 1842657 >>> >>> URL: http://svn.apache.org/viewvc?rev=1842657&view=rev >>> Log: >>> Fixed test cases that errored due to path case sentsitivity on Windows >> >> I looked at our compat classes an hour ago for totally different >> reasons, but I noticed something you might want to use: >> >> import org.apache.tomcat.util.compat.JrePlatform; >> >>         if (JrePlatform.IS_WINDOWS) ... >> > > Thanks for pointing that out.  I was trying to find out how it was > done elsewhere in the code and saw > >     System.getProperty("os.name").startsWith("Windows")); > > at > http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java?r1=1842657&r2=1842656&pathrev=1842657 > > So I based my patch on that.  I will update my patch according to your > feedback, which is a much cleaner solution. Corrected in r1842664. Thanks, Igal --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org