tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo
Date Wed, 03 Oct 2018 10:27:02 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757

--- Comment #9 from Jordi Llach <jllachf@gmail.com> ---

The way you've solved the issue in JspServletWrapper's loadTagFile method by
checking whether tagHandlerClass is null (in the second synchronized block) is
better than mine. Also, removing firstTime from JspServletWrapper's
getReloadInternal method makes a lot of sense

I agree that checking "firstTime" and "theServlet / tagHandlerClass" attributes
overlaps someway, but firstTime also allows us to to avoid checking whether we
have to compile the same resource multiple times in a scenario with multiple
concurrent requests, by avoiding the the call to Compiler's isOutDated method
on each concurrent request (this could be relevant with complex nested jsp/tag
files)

Because of that IMHO I would suggest the following changes in JspServletWrapper
class

- service method : I would check firstTime flag instead of theServlet
- loadTagFile method : in the first synchronized block I would use firstTime
flag instead of checking whether tagHandlerClass is null

Maybe firstTime should be renamed to compile ?

The most important thing ... I've tested the patch and it solves the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message