tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keiichi Fujino <keiichi.fuj...@gmail.com>
Subject Re: svn commit: r1843886 - in /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud: CloudMembershipService.java KubernetesMembershipProvider.java
Date Tue, 16 Oct 2018 07:48:35 GMT
2018年10月16日(火) 16:33 Rémy Maucherat <remm@apache.org>:

> On Tue, Oct 16, 2018 at 7:37 AM Keiichi Fujino <kfujino@apache.org> wrote:
>
> > 2018年10月15日(月) 17:39 <remm@apache.org>:
> >
> >
> > > +                byte[] id =
> > > md5.digest(uid.getBytes(StandardCharsets.US_ASCII));
> > >                  member.setUniqueId(id);
> > >                  members.add(member);
> > >              }
> > >
> > >
> > >
> > >
> > Thanks for the fix.
> >
> > Is this uniqueId 16 bytes?
> > The uniqueId should be 16 bytes in channel Specs.
> >
> > The MD5 should be a 128bit crap hash. The straight pod id is not 16
> bytes,
> so that's the reason for the md5.
>
> Rémy
>

ok. thanks.

-- 
Keiichi.Fujino

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message