tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: Refactoring and Cleanup of OS Name property usage
Date Wed, 03 Oct 2018 17:04:08 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Igal,

On 10/2/18 18:54, Igal Sapir wrote:
> Rainer pointed out to me the class JrePlatform [1], which has a
> helper field called IS_WINDOWS.
> 
> I think that it would make sense to add a constant field OS_NAME,
> as well as IS_LINUX and IS_MACOS, and use these fields instead of
> calling System.getProperty("os.name") in multiple places - some
> examples [2] [3] [4].
> 
> If there is no objection, I can go ahead and refactor that.

+1

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlu09ogACgkQHPApP6U8
pFjXHQ//XUz9mDXA8hUFxL+6Ck/xjDiExUjTFwV7rm0hYWjaeECHqz5tgZ5h3FAy
2S2JaICB1+BhzBPQAkVrruadIqy4X5pIOs4cekZcOGtxThxRTPPOTedhjktXMy6s
Yd5p0DHpkqy2zZFUQWnpXfuQNqrQv3fL6Reqed5EOeoFRvTKjGM8XiUeoRA1+rIB
r0fT0zZDO5im9GEdev4nSbrUE74vPZMHnBH1ykKMB9zWQVwnkIfajCaJMuV7glrj
T6dOJa6z15hMfSOkrX0xy6AaB0GpMhh9kZuYjySXW5n6tPNIMNNX+x+j+Xu7nQnS
MRkYe+2zNSS8GUT638e026loH8XDA3ortvnXZ+mdK01RMGe+4hRR2OKPoaok3qaQ
tInLACtWun6tEsAtGLhVcn2gEO60y22r+d+bOLKOz7G7+9D1aKRQIfMnO9wc5ogG
O4dAhlSXLn3fE16vlL1jyzbje3D85jEUYT6tkT7ee307BbVflfZ9+OGb8tUjjfMl
iUNWmUz6ly4caZD28VlenLM8rRu4HZZ/684wQl6SvJCAp60Irk/WfM7T1zNO3vjr
xVaR+S3G+elNLmnoGLcF6538aket7x+1ixnG67Cs3gRRlhtuSMEHThZHNTR4ecob
uPu9eiKfIaa3W7g67FPQkxZp2TnzeshPKUjTMdoiX0V4N3Zz2kU=
=J0yo
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message