tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1842657 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java catalina/webresources/TestAbstractArchiveResource.java catalina/webresources/TestFileResource.java coyote/http2/Http2TestBase.java
Date Wed, 03 Oct 2018 11:39:07 GMT
On 03/10/18 11:17, Mark Thomas wrote:
> On 02/10/18 22:39, isapir@apache.org wrote:
>> Author: isapir
>> Date: Tue Oct  2 21:39:57 2018
>> New Revision: 1842657
>>
>> URL: http://svn.apache.org/viewvc?rev=1842657&view=rev
>> Log:
>> Fixed test cases that errored due to path case sentsitivity on Windows
> 
> This looks to be addressing the symptom rather than the root cause.
> 
> URLs should be case sensitive so converting them to lower case before
> comparing them may hide future regressions.
> 
> I suspect an issue with getAbsolutePath() vs getCanonicalPath() but that
> is only a guess as to what the root cause might be.
> 
> I'm looking to see if I can recreate the original problem.

Found it. The basis of all the resource URLs is the Context's docBase.
It is using getCanonicalPath() (actually there is a case where it
doesn't - that is a separate bug).

The unit test therefore needs to use getCanonicalPath() as well.

Fixed in svn.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message