From dev-return-190865-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed May 16 16:25:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B8BBD180669 for ; Wed, 16 May 2018 16:25:11 +0200 (CEST) Received: (qmail 46512 invoked by uid 500); 16 May 2018 14:25:10 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 46496 invoked by uid 99); 16 May 2018 14:25:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 14:25:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E37F9CAE32 for ; Wed, 16 May 2018 14:25:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.13 X-Spam-Level: X-Spam-Status: No, score=-0.13 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_SHORT=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qzznjSgJVxoK for ; Wed, 16 May 2018 14:25:09 +0000 (UTC) Received: from mail-it0-f67.google.com (mail-it0-f67.google.com [209.85.214.67]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E80AE5F3F4 for ; Wed, 16 May 2018 14:25:08 +0000 (UTC) Received: by mail-it0-f67.google.com with SMTP id n202-v6so2329812ita.1 for ; Wed, 16 May 2018 07:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=C7D/gF0s4SSS2p022dvY7P/lk120BPpu3A48dnjSgHI=; b=SjuLa8n1vEQkM9x0pXNDkAD5+jtS6hqzy9pN1euF6N34QrdAVr4S5OLEfKM1taAnzx xRIbFyBre/oEndVX4dAw8D5k9VcqA4pWYyt1DUus0n7aL78tBmYpcC8MoUUXkOgxZ9yZ 4cA/15KsZYH1ckgfMI+VrF0pqyCoqgy0ciz+RfBxKQIMsppQnCGJfebQ16Eh7sL69zZN JAwJ5/wqybqk3xJxFuRnQF1LU5HiLAE7+2BEmrFU+7Mz3RWvZSoehSzRgrCoGEVoj3oT Q5B74Mhml1goVtUEeF9G2V71rUgsKp6Q1AmMHP0c7g5YnTqO0QzJOlwV7W/OD0tkfEy+ dh4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=C7D/gF0s4SSS2p022dvY7P/lk120BPpu3A48dnjSgHI=; b=qc/uccIEgY1qQfIljNTy9CMp9U1TMEqgT33VO6GYFeJW0LYu5HLkFSgU00FlpqSUTn aQbjbXZc/7XxGWjVS1sGqnM31mEqklAqcQhmM0s3sWb9LGmOKMacgQkZqxdUscUBxoti IvkSi/BAXNa36UgKunNhSB7BFSc/bmilGBXCwfrjgl5YfPG2GzFNXgJ6byF3txT++zQM AfiQWALZ1GEALPpVEMgY4ROfUsggZOR+GynbKyc8SqRzFAmTS5SmZ9nxo+0sYtKLbCUE Lg8Bm7H4g12mBacXJq2U3x/DIwk3BICsI+O9NJuEowgGANTsQHYhvZEWASf9HkWubd7S n38A== X-Gm-Message-State: ALKqPwcKOzJDYUaD+Zc5BeIuNQSKXLmn07PJn+gZ5ra7erOTwxNC4gyt wynOSBaadYLRBDzNUZsXx0/liQu4yjHCSaPABDUjQmka X-Google-Smtp-Source: AB8JxZpKhFkVbxqsOJPkzciyNbW/mRtZ6TPA+4bjnhxE2LGHoQCx8HufndYjm2XMgSwmttMrvx0ary8Sv27RJKKZrpE= X-Received: by 2002:a24:98c5:: with SMTP id n188-v6mr1313250itd.150.1526480708097; Wed, 16 May 2018 07:25:08 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:7207:0:0:0:0:0 with HTTP; Wed, 16 May 2018 07:25:07 -0700 (PDT) In-Reply-To: References: <20180516100331.A119C3A0163@svn01-us-west.apache.org> From: Konstantin Kolinko Date: Wed, 16 May 2018 17:25:07 +0300 Message-ID: Subject: Re: svn commit: r1831691 - in /tomcat/trunk: java/org/apache/jasper/JspC.java java/org/apache/jasper/resources/LocalStrings.properties webapps/docs/changelog.xml To: Tomcat Developers List Content-Type: text/plain; charset="UTF-8" 2018-05-16 16:47 GMT+03:00 Mark Thomas : > On 16/05/18 14:31, Konstantin Kolinko wrote: >> 2018-05-16 13:03 GMT+03:00 : >>> @@ -205,6 +206,22 @@ Automatically created by Apache Tomcat J >>> jspc.webxml.footer=\n\ >>> \n\ >>> \n >>> +jspc.webfrg.header=\n\ >>> +>> +\ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"\n\ >>> +\ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee\n\ >>> +\ http://java.sun.com/xml/ns/javaee/web-fragment_3_0.xsd"\n\ >>> +\ version="3.0"\n\ >> >> 4) Update version, namespace, schema to 3.1 for Tomcat 8.0, 8.5, 4.0 >> for Tomcat 9 ? > > The web.xml generation sticks to Servlet 2.5. I decided to stick to the > lowest useable version number for the fragment as well since I could not > see any benefit in generating a file with later version number. > As precompilation targets a specific release of Tomcat, and is not guaranteed to be compatible with a different build release, I see no benefit in trying to be compatible. Regarding "Servlet 2.5" (or 2.3 actually) comment 4 (April 2014) in this bug 50234 has a complaint about it: [quote] At the moment (Tomcat 7), a dummy web.xml has to be defined in order to define the version (i.e. for expresions within the JSPs). [/quote] https://bz.apache.org/bugzilla/show_bug.cgi?id=50234 Sticking to 2.3 is OK when inserting a fragment into existing web.xml. When generating a new web.xml, one ends up with a web application that uses a different version of spec as opposed to a web app without a web.xml file. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org