From dev-return-190827-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Mon May 14 13:41:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0CECA180627 for ; Mon, 14 May 2018 13:41:54 +0200 (CEST) Received: (qmail 96639 invoked by uid 500); 14 May 2018 11:41:53 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 96628 invoked by uid 99); 14 May 2018 11:41:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 May 2018 11:41:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4A34C180675 for ; Mon, 14 May 2018 11:41:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.011 X-Spam-Level: X-Spam-Status: No, score=-0.011 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id eMV8KFmwKj-I for ; Mon, 14 May 2018 11:41:51 +0000 (UTC) Received: from mailserver.kippdata.de (mailserver.kippdata.de [212.79.170.253]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D7B3B5F398 for ; Mon, 14 May 2018 11:41:50 +0000 (UTC) Received: from [195.227.30.209] (notebook-rj [195.227.30.209]) by mailserver.kippdata.de (8.13.5/8.13.5) with ESMTP id w4EBfnUY014238 for ; Mon, 14 May 2018 13:41:49 +0200 (CEST) Subject: Re: svn commit: r1830251 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java res/maven/mvn-pub.xml test/org/apache/tomcat/util/http/parser/TestHttpParserHost.java webapps/docs/changelog.xml To: Tomcat Developers List References: <20180426180919.EB4AB3A00E7@svn01-us-west.apache.org> <99866be0-7ab2-e3e4-f033-b1161f958458@apache.org> <2f2ec83b-c079-4849-79fb-3babe03b0309@apache.org> From: Rainer Jung Message-ID: <968a36dc-2f1e-8f4e-5e43-db00e48bc188@kippdata.de> Date: Mon, 14 May 2018 13:41:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2f2ec83b-c079-4849-79fb-3babe03b0309@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit Am 30.04.2018 um 10:28 schrieb Mark Thomas: > On 29/04/18 23:14, Violeta Georgieva wrote: >> On Sun, 29 Apr 2018 at 17:10, Violeta Georgieva >> wrote: >>> On Sun, 29 Apr 2018 at 6:54, Mark Thomas wrote: >>>> On 28/04/18 17:50, Violeta Georgieva wrote: > > > >>>>> Is this file really part of that change? >>>> >>>> No. I think it got caught up with that commit by mistake. I don't think >>>> it does any harm though. >>>> >>> >>> Only for the release ;) > > Sorry. > >> If you don’t mind I’ll revert this file to its previous version. Wdyt? > > No objection. > > Looking at the diff, there are rather more changes between 8.0.x and > 8.5.x than I was expecting. Another option would be to update 8.0.x with > all the changes from 8.5.x and 9.0.x (and the same for 7.0.x). I'd be > happy to do that if folks are agreeable. In addition: I have the feeling that the following lines are now broken in 8.0: The at sign notation ("@") does not work for me here. 8.5 and 9.0 have a dollar sign in place there: which seems to make it work. Furthermore in lines 173/174 there's a "zip" suffix missing. My current patch would be: Index: res/maven/mvn-pub.xml =================================================================== --- res/maven/mvn-pub.xml (revision 1831386) +++ res/maven/mvn-pub.xml (working copy) @@ -50,16 +50,16 @@ - - + + - - + + - - + + @@ -115,12 +115,12 @@ - - + + - - + + @@ -170,16 +170,16 @@ - - + + - - + + - - + + Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org