From dev-return-189871-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed Mar 28 20:25:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9CB71180652 for ; Wed, 28 Mar 2018 20:25:57 +0200 (CEST) Received: (qmail 98849 invoked by uid 500); 28 Mar 2018 18:25:56 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 98839 invoked by uid 99); 28 Mar 2018 18:25:56 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2018 18:25:56 +0000 Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 661CCBDB for ; Wed, 28 Mar 2018 18:25:55 +0000 (UTC) Received: by mail-io0-f172.google.com with SMTP id 141so4626474iou.12 for ; Wed, 28 Mar 2018 11:25:55 -0700 (PDT) X-Gm-Message-State: AElRT7ElJ0wY6OFT2/V9g+lCwcjmCks8KmrKVKsWtLFJ7KF9YFO5rz+r fn5I1b4sQ5oRwjoBLhVhV2WC/7grDKSuggCK76E= X-Google-Smtp-Source: AIpwx4/tqee9BoEzFA3pF3nzhHFbieo3vHii4iQ3BYoCYfclHk+/rKgauK6TgpafbHqAEYVcWG+Auy8DYRM2lHZUD1w= X-Received: by 10.107.58.213 with SMTP id h204mr17720777ioa.265.1522261553916; Wed, 28 Mar 2018 11:25:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.84.202 with HTTP; Wed, 28 Mar 2018 11:25:53 -0700 (PDT) From: =?UTF-8?Q?R=C3=A9my_Maucherat?= Date: Wed, 28 Mar 2018 20:25:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: DBCP2 in Tomcat To: Tomcat Developers List Content-Type: multipart/alternative; boundary="001a114ac34c2d4a3e05687d23b4" --001a114ac34c2d4a3e05687d23b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, In Tomcat, DBCP2 is missing the XA portion (all contained in a single "managed" package). So at work I now got some people asking about that removal, and that's always a bit annoying as they have to go to a separate vanilla DBCP2 to get the functionality. Annoying sometimes. So it would be possible to add the classes in Tomcat (including the javax.transaction to build, as that's the Tomcat way to deal with that), even though the user would need to add its own transaction manager to do anything with it. Should I now add it (only in 9/trunk) or instead leave things the way they are ? Both work to be honest, it's just that I've been bitten by the "we only ship 3/4 of DBCP and I didn't know it" bug. R=C3=A9my --001a114ac34c2d4a3e05687d23b4--