tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 62160] Property values linking
Date Tue, 06 Mar 2018 20:45:33 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=62160

Konstantin Kolinko <knst.kolinko@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
I am OK with the feature, but I am -1 on the approach implemented in this patch
(r1825989).

1). Consider the following properties:
first=${
second=bar}
bar=baz

If you have value="${first}${second}" my expectation is that result of
substitution will be value="${bar}". Your algorithm will yield value="baz".

I think the replacement loop should be inside of
IntrospectionUtils.replaceProperties(),
looking for replacements in the value of a property.

Instead of looping over resulting value.

2). It would be better to have some hard limit on recursion depth. E.g. 20.
(Not a showstopper requirement, but a "nice to have" one).

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message