tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1825946 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Date Mon, 05 Mar 2018 22:16:35 GMT
Author: markt
Date: Mon Mar  5 22:16:35 2018
New Revision: 1825946

URL: http://svn.apache.org/viewvc?rev=1825946&view=rev
Log:
False positives in Realm package

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1825946&r1=1825945&r2=1825946&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Mon Mar  5 22:16:35 2018
@@ -339,6 +339,15 @@
     <Bug code="IS" />
   </Match>
   <Match>
+    <!-- Sync is protecting preparedRoles, not these fields -->
+    <Class name="org.apache.catalina.realm.JDBCRealm" />
+    <Or>
+      <Field name="roleNameCol" />
+      <Field name="userRoleTable" />
+    </Or>
+    <Bug pattern="IS2_INCONSISTENT_SYNC " />
+  </Match>
+  <Match>
     <!-- roles will be initialized in addAttributeValues -->
     <Class name="org.apache.catalina.realm.JNDIRealm" />
     <Or>
@@ -348,6 +357,12 @@
     <Bug code="NP" />
   </Match>
   <Match>
+    <!-- Sync is protecting authenticate90, not this field -->
+    <Class name="org.apache.catalina.realm.JNDIRealm" />
+    <Field name="userPatternFormatArray" />
+    <Bug pattern="IS2_INCONSISTENT_SYNC " />
+  </Match>
+  <Match>
     <!-- request.getRequestPathMB(), request.getQueryString() can be null because
     o.a.t.util.buf.MessageBytes.toString() can return NULL -->
     <Class name="org.apache.catalina.realm.RealmBase"/>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message