tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1822942 - /tomcat/trunk/res/findbugs/filter-false-positives.xml
Date Fri, 02 Feb 2018 10:49:21 GMT
Author: markt
Date: Fri Feb  2 10:49:21 2018
New Revision: 1822942

URL: http://svn.apache.org/viewvc?rev=1822942&view=rev
Log:
SpotBugs
Exclude a couple of false positives

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1822942&r1=1822941&r2=1822942&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Fri Feb  2 10:49:21 2018
@@ -895,14 +895,19 @@
     <Bug code="SF" />
   </Match>
   <Match>
-    <!-- Returning null here is fine -->
-    <Class name="org.apache.tomcat.util.buf.ByteChunk"/>
-    <Method name="toString"/>
-    <Bug code="NP" />
+    <!-- Handled by abstract base class -->
+    <Or>
+      <Class name="org.apache.tomcat.util.buf.ByteChunk"/>
+      <Class name="org.apache.tomcat.util.buf.CharChunk"/>
+    </Or>
+    <Bug pattern="HE_EQUALS_NO_HASHCODE" />
   </Match>
   <Match>
     <!-- Returning null here is fine -->
-    <Class name="org.apache.tomcat.util.buf.CharChunk"/>
+    <Or>
+      <Class name="org.apache.tomcat.util.buf.ByteChunk"/>
+      <Class name="org.apache.tomcat.util.buf.CharChunk"/>
+    </Or>
     <Method name="toString"/>
     <Bug code="NP" />
   </Match>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message