tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1805960 - in /tomcat/native/trunk: native/Makefile.in native/configure.in xdocs/miscellaneous/changelog.xml
Date Thu, 24 Aug 2017 20:58:43 GMT
2017-08-24 21:33 GMT+03:00 Mark Thomas <markt@apache.org>:
> On 24/08/17 11:19, Konstantin Kolinko wrote:
>> A naive review below. I do not have a working tc-native build to check.
>>
>> I think your patch is an adaptation of r1805943 (BZ 60290). As such,
>> it looks good.
>>
>> Several thoughts:
>> 1) A typo in commit message and in changelog.xml>
>> I think it was meant to be  s/but setting/by setting/.
>
> Thanks. Fixed.
>
> I think Rainer has answered the libtool questions.

Ack. Good answers. Thank you both.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message