Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Subject: Re: svn commit: r1711667 - in /tomcat/native/trunk/native: ./
 src/sslcontext.c
To: Tomcat Developers List <dev@tomcat.apache.org>
References: <20151031185758.8A1F23A027C@svn01-us-west.apache.org>
From: Christopher Schultz <chris@christopherschultz.net>
Message-id: <5637740A.2040502@christopherschultz.net>
Date: Mon, 02 Nov 2015 09:32:42 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <20151031185758.8A1F23A027C@svn01-us-west.apache.org>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit

Mark,

On 10/31/15 2:57 PM, markt@apache.org wrote:
> Author: markt
> Date: Sat Oct 31 18:57:58 2015
> New Revision: 1711667
> 
> URL: http://svn.apache.org/viewvc?rev=1711667&view=rev
> Log:
> Update ignores
> 
> Modified:
>     tomcat/native/trunk/native/   (props changed)
>     tomcat/native/trunk/native/src/sslcontext.c
> 
> Propchange: tomcat/native/trunk/native/
> ------------------------------------------------------------------------------
> --- svn:ignore (added)
> +++ svn:ignore Sat Oct 31 18:57:58 2015
> @@ -0,0 +1,9 @@
> +.make.dirs
> +Makefile
> +build-outputs.mk
> +config.log
> +config.nice
> +config.status
> +configure
> +tcnative.pc
> +tcnative.spec
> 
> Modified: tomcat/native/trunk/native/src/sslcontext.c
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslcontext.c?rev=1711667&r1=1711666&r2=1711667&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/src/sslcontext.c (original)
> +++ tomcat/native/trunk/native/src/sslcontext.c Sat Oct 31 18:57:58 2015
> @@ -106,12 +106,14 @@ int ssl_callback_ServerNameIndication(SS
>      hostname = (*env)->NewStringUTF(env, servername);
>      original_ssl_context = P2J(c->ctx);
>  
> -    // Make the call
> -    new_ssl_context = (*env)->CallStaticLongMethod(env,
> -                                                            ssl_context_class,
> -                                                            sni_java_callback,
> -                                                            original_ssl_context,
> -                                                            hostname);
> +    // Make the call only if the statis methos exists
> +    if (sni_java_callback != 0) {
> +        new_ssl_context = (*env)->CallStaticLongMethod(env,
> +                                                       ssl_context_class,
> +                                                       sni_java_callback,
> +                                                       original_ssl_context,
> +                                                       hostname);
> +    }
>  
>      if (original_ssl_context != new_ssl_context) {
>          SSL_set_SSL_CTX(ssl, J2P(new_ssl_context, SSL_CTX *));
> @@ -283,6 +285,10 @@ TCN_IMPLEMENT_CALL(jlong, SSLContext, ma
>          ssl_context_class = (*e)->NewGlobalRef(e, o);
>          sni_java_callback = (*e)->GetStaticMethodID(e, ssl_context_class,
>                                                      "sniCallBack", "(JLjava/lang/String;)J");
> +        /* Older Tomcat versions may not have this static method */
> +        if ( JNI_TRUE == (*e)->ExceptionCheck(e) ) {
> +            (*e)->ExceptionClear(e);
> +        }
>      }
>  
>      /* Set up OpenSSL call back if SNI is provided by the client */

This commit looks to be more extensive than the commit comment would
suggest.

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org