tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58646] NullPointerException in InternalNioOutputBuffer under traffic related to <async-supported> config.
Date Tue, 24 Nov 2015 22:53:53 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=58646

--- Comment #3 from Konstantin Kolinko <knst.kolinko@gmail.com> ---
1)
> Nov 23, 2015 CST 08:34:58.115 PM org.apache.coyote.http11.Http11NioProcessor
> INFO: Error parsing HTTP request header
> Note: further occurrences of HTTP header parsing errors will be logged at DEBUG level.

The above logging is controlled by
org.apache.juli.logging.UserDataHelper.CONFIG system property [1].

The log message was likely written by "catch (Throwable t)" clause in
AbstractHttp11Processor.process(). That is the only place where UserDataHelper
is used in a processor.

Unfortunately, it does not log the stacktrace, even with debug logging. It can
be improved with a code change in AbstractHttp11Processor.java line 1058,

-                            getLog().debug(message);
+                            getLog().debug(message, t);

(An easy test case: I have seen such messages when erroneously trying to
connect with https:// to a http connector.)


2)
I do not see thread names in your log. It is likely that the two errors are
related (being just 3ms apart), but it is unclear whether the two errors
occurred in the same thread.

It is known that org.apache.juli.OneLineFormatter writes the thread names.


3) Usual advice with misbehaving requests/responses is to add the following
property into conf/catalina.properties file:  [2]

org.apache.catalina.connector.RECYCLE_FACADES=true

It should make your configuration more robust against common mistake of
accessing Request/Response objects outside of their life cycle.


4) BTW, Tomcat 8.0.29 was released several hours ago. I think that it will be
announced tomorrow.


[1] http://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html#Logging
[2]
http://tomcat.apache.org/tomcat-8.0-doc/security-howto.html#System_Properties

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message