tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 57977] The original class loader isn't re-bound to the thread in PersistentValve.invoke()
Date Mon, 08 Jun 2015 15:42:19 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=57977

Remy Maucherat <remm@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |minor

--- Comment #4 from Remy Maucherat <remm@apache.org> ---
Actually, the patch looks wrong. If the valve is set at the host level (or
below), then nothing is needed, the host valve is the one supposed to be doing
the context classloader setting. If somehow the valve is located at the engine
level, then this looks rather weird (but maybe it's nice if there are lots of
vhosts), and in that case it needs to set the context classloader (and some
more - normally any such change is supposed to be done with context.(un)bind
now).

Since PersistentValve is not documented anywhere, the its use is questionable
(non sticky sessions are not really allowed), I'd add a note in the javadoc
saying it should be associated to a Host or Context.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message