tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 47323] Name clash: o.a.c.Manager class vs. o.a.c.manager package when compiling JSP
Date Tue, 06 May 2014 17:13:35 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47323

--- Comment #7 from Christopher Schultz <chris@christopherschultz.net> ---
(In reply to Konstantin Kolinko from comment #6)
> > request the resource as a URI
> 
> classLoader.getResource(packageName)
> 
> I suspect that it can break compilation for JARs that contain only files and
> do not have zip entries for directories. I mean, it will return null, a
> false negative. (It needs testing though whether my suspicion is true).

Agreed. In the JARs we control, we could make sure that directories are
included, but that won't help user code and 3rd-party libraries.

> BTW,
> the strings arithmetics in org.apache.jasper.compiler.JDTCompiler$(new
> INameEnvironment).isPackage(char[][],char[]) is awful.
> 
> It uses += concatenating strings in a loop.

Yikes. It's used all over the place in the "new INameEnvironment" construct.
Also creating String objects out of char[] just to then concatenate with the
ever-expanding String value.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message