tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1559707 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/webapp/bug5nnnn/bug56029.jspx
Date Mon, 20 Jan 2014 19:42:33 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 20/01/2014 18:25, Jeremy Boynes wrote:
> On Jan 20, 2014, at 6:22 AM, markt@apache.org wrote:
> 
>> Author: markt Date: Mon Jan 20 14:22:49 2014 New Revision:
>> 1559707
>> 
>> URL: http://svn.apache.org/r1559707 Log: Additional fix for bug
>> 56029. Now whitespace is not skipped, make sure it is trimmed
>> before the function name is used. Includes a test case based on a
>> jspx file by kkolinko.
> 
> I think this caused TestELParser to start failing. I committed a
> change http://svn.apache.org/r1559798 that I think fixes that but
> would appreciate a second set of eyes before back-porting to
> 7.0.x.

Thanks. Eclipse was nagging me about that but I missed it.#

The fix looks good to me.

Mark

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS3XwpAAoJEBDAHFovYFnnaNoP/1NAp7qmYALt+URrAPJk9MOs
CQvcC7inkjDhHmOoNConJUO9Jq9AVMLDfZFYrqqmk0+fWLCUyoembER+j7PcYa1T
0MtRbpuYfwjkVfwMQxLZfWrnp8IhUVGEndgkCsX5J53P3heZnfb1kMj+ySU2iz0T
ap4fBr4sQKullHCea0FK9wXMojNzmWn0IyommyCONod6AgCEKPg5LnmGv4BXEMWx
EmhThybVzWjVO00iiNLuIT9cyGYIAh01iBeB/vQFwbfcB/vFmfT3ypdhb+h7JpM4
fkM4DWChfRmmSXNk8+4oDndxYq3oLB+fnQAx+kqIfIaz448Foad4n7EQRBguXUWz
VBmGwhnNHPMnEgoui7XJ6/1+6+nNE0wcJjfGGyA675zkH90eUhDc7ViRgPaUUZPu
dpQn95WDVDQVXCBH0sIrOVAT1TOb0hY/EALx0QMixqnpLS8iEgMbWLxZMqzn6Ebw
nkxoGiHITNzOQ5WlNUXcTMB22XDJTlmmiy1ELywRg6tSzyh5iqkkTKqdXc90QTIF
B18rH69bMAaG6onhHEya4cAgb7va0aKOhuvsIHb65cuaJpZYwrHQHMnZkzAaQbyq
yT/ia0tytDnEr875DceVJS8+xzLRGtubUlNB7i/ExDgUKJWE1cUiRV6eXHSa57mv
1rZHbUXV1T7spvDiTRD0
=K7z+
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message