Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5709F20E for ; Tue, 1 Oct 2013 13:08:29 +0000 (UTC) Received: (qmail 9018 invoked by uid 500); 1 Oct 2013 13:08:25 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 8918 invoked by uid 500); 1 Oct 2013 13:08:24 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 8901 invoked by uid 99); 1 Oct 2013 13:08:24 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2013 13:08:24 +0000 Date: Tue, 1 Oct 2013 13:08:24 +0000 (UTC) From: "Hudson (JIRA)" To: dev@tomcat.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MTOMCAT-240?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D137= 82909#comment-13782909 ]=20 Hudson commented on MTOMCAT-240: -------------------------------- SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #256 (See [https://builds.a= pache.org/job/TomcatMavenPlugin-mvn3.x/256/]) [MTOMCAT-240] Artifacts with same artifactID but different groupID are skip= ped Submitted by Petar Tahchiev (olamy: http://svn.apache.org/viewvc/?view=3Dr= ev&rev=3D1528073) * /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/a= pache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java > Artifacts with same artifactID but different groupID are skipped > ---------------------------------------------------------------- > > Key: MTOMCAT-240 > URL: https://issues.apache.org/jira/browse/MTOMCAT-240 > Project: Apache Tomcat Maven Plugin > Issue Type: Bug > Components: commons-lib > Affects Versions: 2.1 > Environment: all > Reporter: Petar Tahchiev > Assignee: Olivier Lamy (*$^=C2=A8%`=C2=A3) > Fix For: 2.2 > > Attachments: MTOMCAT-240.patch > > > Hi guys, > I have the following situation: my classpath includes the following artif= acts: > 1) artifactA in group com.mygroup > 2) artifactA in group com.myothergroup. > Looking in DefaultClassLoaderEntriesCalculator.java on line 120 we see th= e following: > {code} > String fileName =3D artifact.getFile().getName(); > if ( !fileInClassLoaderEntries.contains( fileName= ) ) { > // add the artifact to the classpath > } > {code} > So in my case both artifacts are resolved as artifactA-1.0-SNAPSHOT.jar s= o the second one gets omitted. I have chaged to code to simply include the = categoryID like this:=20 > {code} > String fileName =3D artifact.getGroupId() + "-" += artifact.getFile().getName(); > if ( !fileInClassLoaderEntries.contains( fileName= ) ) { > //add to classpath > } > {code} > and it works like a charm. > You can find the patch attached. Please review it and apply. -- This message was sent by Atlassian JIRA (v6.1#6144) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org