Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CD4B10A56 for ; Thu, 27 Jun 2013 23:15:14 +0000 (UTC) Received: (qmail 74265 invoked by uid 500); 27 Jun 2013 23:15:13 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 74186 invoked by uid 500); 27 Jun 2013 23:15:13 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 74177 invoked by uid 99); 27 Jun 2013 23:15:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2013 23:15:13 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of knst.kolinko@gmail.com designates 209.85.214.178 as permitted sender) Received: from [209.85.214.178] (HELO mail-ob0-f178.google.com) (209.85.214.178) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Jun 2013 23:15:08 +0000 Received: by mail-ob0-f178.google.com with SMTP id fb19so1327477obc.23 for ; Thu, 27 Jun 2013 16:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=SUAliAIGBa7F596UcNU5tU6Vz+svHHbdU8FCMR7BnLk=; b=Ie3dHKG4/MHYeJhQpq3QOfr7SzPuEoButUyantllzN7eYchcIqapn918CXZeqCXbMI mcjSuuX82TJoZAXfgp1ygjKUIEkrySYspBJfCfepusytoGO0iqozaTRB7c/lLyGzLJw5 HoERzvGO+snhi4lLbn3hkOvgMiv4JPtJhu2tPyyDqnCfv+xT/IrMk05eutZcWPTB9Klb 20sRZNpIwRQEK0a+Fbe1aPCopqihwIAfWyESsjBJbkf2uHwJm3IIHZSmBpE4fsb/xvU7 p/GByYIzxF9k9JD011XvuabbfVg2uCzstj+lftdgZLIHxfFkg7NO51RcbkoM2/Ni582g 2k3w== MIME-Version: 1.0 X-Received: by 10.182.230.198 with SMTP id ta6mr5182912obc.98.1372374887003; Thu, 27 Jun 2013 16:14:47 -0700 (PDT) Received: by 10.76.70.198 with HTTP; Thu, 27 Jun 2013 16:14:46 -0700 (PDT) In-Reply-To: <20130627201040.5C5E52388993@eris.apache.org> References: <20130627201040.5C5E52388993@eris.apache.org> Date: Fri, 28 Jun 2013 03:14:46 +0400 Message-ID: Subject: Re: svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java From: Konstantin Kolinko To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org 2013/6/28 : > Author: markt > Date: Thu Jun 27 20:10:40 2013 > New Revision: 1497552 > > URL: http://svn.apache.org/r1497552 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 > Fix bugs in test > > Modified: > tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java > > Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java?rev=1497552&r1=1497551&r2=1497552&view=diff > ============================================================================== > --- tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java (original) > +++ tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Thu Jun 27 20:10:40 2013 > @@ -108,7 +108,7 @@ public class TestEncodingDecoding extend > Assert.assertEquals(MESSAGE_ONE, > ((MsgString) MsgStringMessageHandler.received.peek()).getData()); > Assert.assertEquals(MESSAGE_ONE, > - ((MsgString) client.received.peek()).getData()); > + new String(((MsgByte) client.received.peek()).getData())); It is "new String(byte[])" here. It would be better with explicit encoding name such as "ISO-8859-1". > session.close(); > } > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org