Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of rainer.jung@kippdata.de
 designates 195.227.30.149 as permitted sender)
Message-ID: <50BC9527.8050201@kippdata.de>
Date: Mon, 03 Dec 2012 13:03:51 +0100
From: Rainer Jung <rainer.jung@kippdata.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: dev@tomcat.apache.org
Subject: Re: svn commit: r1415081 - in /tomcat/tc7.0.x/trunk: ./
 java/org/apache/catalina/valves/
 webapps/docs/ webapps/docs/config/
References: <20121129083352.4008823889E2@eris.apache.org>
 <CABzHfVmiQ+wMb2D6wNy_qZS_LmFkfGNUD-h4pK7HZaqSH=cPdQ@mail.gmail.com>
In-Reply-To: 
 <CABzHfVmiQ+wMb2D6wNy_qZS_LmFkfGNUD-h4pK7HZaqSH=cPdQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 03.12.2012 12:09, Konstantin Kolinko wrote:
> 2012/11/29  <rjung@apache.org>:
>> Author: rjung
>> Date: Thu Nov 29 08:33:47 2012
>> New Revision: 1415081
>>
>> URL: http://svn.apache.org/viewvc?rev=1415081&view=rev
>> Log:
>> Add new ALV attribute "renameOnRotate" (Default:false).
>>
>> If set to "true", the "fileDateFormat" will not be part
>> of the current log file. Only at the time of log rotation
>> the file is renamed to the final name including the
>> "fileDateFormat".
>>
>> This mimics the behavior e.g. of Log4J and similar frameworks,
>> where the active file does not have the timestamp in the file
>> name.
>>
>> Pro: current file has stable name, all files with
>>      timestamp in name are old.
>> Con: Slightly more complex impl.
>>
>> Backport of r1414889 from trunk.
>>
>> Modified:
>>     tomcat/tc7.0.x/trunk/   (props changed)
>>     tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
>>     tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/LocalStrings.properties
>>     tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
>>     tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>>     tomcat/tc7.0.x/trunk/webapps/docs/config/valve.xml
>>
> 
> Interesting.
> Several notes. Just informational.
> a) It should be easy to extend this to skip rotation if file.length() is 0.

Not so sure about that one. An empty rotated file shows there was
nothing written. Skipping rotation might lead to the question, whether
rotation is broken (or the server was down during the change of date).

So I'd prefer keeping the rotation since it isn't so expensive and
doesn't happen to early.

But maybe I misunderstood you.

Regards,

Rainer

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org