tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
Date Mon, 18 Jun 2012 08:27:24 GMT
2012/6/18 Bill Barker <billbarker@apache.org>:
>    - tomcat-trunk-validate :  Tomcat 8.x, a web server implementing Java Servlet 3.1,
>
> validate:
>    [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
> [checkstyle] Running Checkstyle 5.6-SNAPSHOT on 2282 files
> [checkstyle] /srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/resources/MANIFEST.MF:2:
Line matches the illegal pattern '\s+$'.
> [checkstyle] /srv/gump/public/workspace/tomcat-trunk/modules/jdbc-pool/resources/MANIFEST.MF:17:
Line matches the illegal pattern '\s+$'.
>
> BUILD FAILED
> /srv/gump/public/workspace/tomcat-trunk/build.xml:461: Got 2 errors and 0 warnings.
>

The file:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/resources/MANIFEST.MF?revision=1144964&view=markup

[[[
Manifest-Version: 1.0
Export-Package:
  org.apache.tomcat.jdbc.pool;version="@VERSION@";
  uses:="javax.management,javax.naming,javax.naming.spi,javax.sql,
  org.apache.tomcat.jdbc.pool.jmx",
  org.apache.tomcat.jdbc.pool.interceptor;version="@VERSION@";
  uses:="javax.management.openmbean,org.apache.tomcat.jdbc.pool",
  org.apache.tomcat.jdbc.pool.jmx;version="@VERSION@";
  uses:="javax.management,org.apache.tomcat.jdbc.pool"
Ant-Version: Apache Ant 1.7.0
Bundle-Vendor: Apache Software Foundation
Bundle-Version: @VERSION@
Bundle-Name: Apache Tomcat JDBC Connection Pool
Bundle-ManifestVersion: 2
Created-By: 11.0-b16 (Sun Microsystems Inc.)
Bundle-SymbolicName: org.apache.tomcat.jdbc
Import-Package:
  javax.management;version="0",
  javax.management.openmbean;version="0",
  javax.naming;version="0",
  javax.sql;version="0",
  org.apache.juli.logging;version="[6.0.18, 7.0.0)"
]]]

There is whitespace after "Export-Package:" and after
"Import-Package:" which is required, because according to grammar [1]
a value always starts with a space.

(value:                          SPACE *otherchar newline *continuation)
(continuation:              SPACE *otherchar newline)

[1] http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html

I am OK to disable the validation for this file, but I I think it
would be better to unwrap the first line of those values. It will be a
bit more ugly but it will avoid problems if there is someone whose
editor is configured to auto-trim the lines.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message