Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 311C4B848 for ; Mon, 2 Jan 2012 12:38:23 +0000 (UTC) Received: (qmail 55235 invoked by uid 500); 2 Jan 2012 12:38:22 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 55171 invoked by uid 500); 2 Jan 2012 12:38:21 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 55162 invoked by uid 99); 2 Jan 2012 12:38:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jan 2012 12:38:21 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of knst.kolinko@gmail.com designates 209.85.220.173 as permitted sender) Received: from [209.85.220.173] (HELO mail-vx0-f173.google.com) (209.85.220.173) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jan 2012 12:38:12 +0000 Received: by vcbfo1 with SMTP id fo1so14227748vcb.18 for ; Mon, 02 Jan 2012 04:37:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=obXrKMgUCFANlWNPt8GI7wGvmPuJ1yNiMngqm8r08gw=; b=ZHcQf+Fl0aN/tQQaPj1kMa5jp7WWN2S0vTvm/RHPBD1GH90ARVvD3HeFiS9fXmBiiV w3kA1bRuyQMA7CcWX36k1QWkePw6wuUdAqr8RBxlt/BNYPQm4xT5eVliR/VuxU/qWliu X09P1HrVbfcHADRDPUN4c5QW5y8HG0KqJp1sM= MIME-Version: 1.0 Received: by 10.52.24.239 with SMTP id x15mr1752099vdf.67.1325507871471; Mon, 02 Jan 2012 04:37:51 -0800 (PST) Received: by 10.52.93.243 with HTTP; Mon, 2 Jan 2012 04:37:51 -0800 (PST) In-Reply-To: <20120102103107.4D4432388980@eris.apache.org> References: <20120102103107.4D4432388980@eris.apache.org> Date: Mon, 2 Jan 2012 16:37:51 +0400 Message-ID: Subject: Re: svn commit: r1226385 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java From: Konstantin Kolinko To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org FYI, I am able to reproduce the failures in this test. Using JDK 6u29 32-bit on WinXP. The exceptions are strange. See below. TEST-org.apache.catalina.startup.TestWebRuleSet.BIO.txt @ r1226397 [[[ Testsuite: org.apache.catalina.startup.TestWebRuleSet Tests run: 7, Failures: 4, Errors: 0, Time elapsed: 0,781 sec ------------- Standard Error ----------------- java.net.MalformedURLException at java.net.URL.(URL.java:601) at java.net.URL.(URL.java:464) at java.net.URL.(URL.java:413) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEn= tity(XMLEntityManager.java:650) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDoc= Version(XMLVersionDetector.java:186) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:772) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.ja= va:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abst= ractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.par= se(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1556) at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:13= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleNameInWebFragmentX= ml(TestWebRuleSet.java:49) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja= va:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe= thod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla= ble.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth= od.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho= d.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4Class= Runner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitT= estRunner.java:518) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUn= itTestRunner.java:1052) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnit= TestRunner.java:906) java.net.MalformedURLException at java.net.URL.(URL.java:601) at java.net.URL.(URL.java:464) at java.net.URL.(URL.java:413) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEn= tity(XMLEntityManager.java:650) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDoc= Version(XMLVersionDetector.java:186) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:772) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.ja= va:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abst= ractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.par= se(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1556) at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:13= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleOrderingInWebFragm= entXml(TestWebRuleSet.java:65) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja= va:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe= thod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla= ble.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth= od.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho= d.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4Class= Runner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitT= estRunner.java:518) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUn= itTestRunner.java:1052) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnit= TestRunner.java:906) java.net.MalformedURLException at java.net.URL.(URL.java:601) at java.net.URL.(URL.java:464) at java.net.URL.(URL.java:413) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEn= tity(XMLEntityManager.java:650) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDoc= Version(XMLVersionDetector.java:186) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:772) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.ja= va:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abst= ractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.par= se(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1556) at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:13= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleOrderingInWebXml(T= estWebRuleSet.java:82) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja= va:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe= thod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla= ble.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth= od.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho= d.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4Class= Runner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitT= estRunner.java:518) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUn= itTestRunner.java:1052) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnit= TestRunner.java:906) java.net.MalformedURLException at java.net.URL.(URL.java:601) at java.net.URL.(URL.java:464) at java.net.URL.(URL.java:413) at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEn= tity(XMLEntityManager.java:650) at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDoc= Version(XMLVersionDetector.java:186) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:772) at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML= 11Configuration.java:737) at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.ja= va:119) at com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(Abst= ractSAXParser.java:1205) at com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.par= se(SAXParserImpl.java:522) at org.apache.tomcat.util.digester.Digester.parse(Digester.java:1556) at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:13= 6) at org.apache.catalina.startup.TestWebRuleSet.testRecycle(TestWebRuleSet.j= ava:98) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.ja= va:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso= rImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMe= thod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCalla= ble.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMeth= od.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMetho= d.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4Class= Runner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunne= r.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitT= estRunner.java:518) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUn= itTestRunner.java:1052) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnit= TestRunner.java:906) ------------- ---------------- --------------- Testcase: testSingleNameInWebFragmentXml took 0,25 sec FAILED junit.framework.AssertionFailedError: at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:14= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleNameInWebFragmentX= ml(TestWebRuleSet.java:49) Testcase: testMultipleNameInWebFragmentXml took 0,016 sec Testcase: testSingleOrderingInWebFragmentXml took 0,094 sec FAILED junit.framework.AssertionFailedError: at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:14= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleOrderingInWebFragm= entXml(TestWebRuleSet.java:65) Testcase: testMultipleOrderingInWebFragmentXml took 0 sec Testcase: testSingleOrderingInWebXml took 0,297 sec FAILED junit.framework.AssertionFailedError: at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:14= 6) at org.apache.catalina.startup.TestWebRuleSet.testSingleOrderingInWebXml(T= estWebRuleSet.java:82) Testcase: testMultipleOrderingInWebXml took 0,015 sec Testcase: testRecycle took 0,094 sec FAILED junit.framework.AssertionFailedError: at org.apache.catalina.startup.TestWebRuleSet.parse(TestWebRuleSet.java:14= 6) at org.apache.catalina.startup.TestWebRuleSet.testRecycle(TestWebRuleSet.j= ava:98) ]]] 2012/1/2 : > Author: markt > Date: Mon Jan =A02 10:31:06 2012 > New Revision: 1226385 > > URL: http://svn.apache.org/viewvc?rev=3D1226385&view=3Drev > Log: > Add some debug that might explain why Gump runs are failing > > Modified: > =A0 =A0tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java > > Modified: tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.ja= va > URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/s= tartup/TestWebRuleSet.java?rev=3D1226385&r1=3D1226384&r2=3D1226385&view=3Dd= iff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java (or= iginal) > +++ tomcat/trunk/test/org/apache/catalina/startup/TestWebRuleSet.java Mon= Jan =A02 10:31:06 2012 > @@ -46,14 +46,14 @@ public class TestWebRuleSet { > > =A0 =A0 =A0 =A0 WebXml webXml =3D new WebXml(); > > - =A0 =A0 =A0 =A0assertTrue(parse(webXml, "web-fragment-1name.xml", true)= ); > + =A0 =A0 =A0 =A0parse(webXml, "web-fragment-1name.xml", true, true); > =A0 =A0 =A0 =A0 assertEquals("name1", webXml.getName()); > =A0 =A0 } > > > =A0 =A0 @Test > =A0 =A0 public void testMultipleNameInWebFragmentXml() throws Exception { > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2name.xml"= , true)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2name.xml", true, fals= e); > =A0 =A0 } > > > @@ -62,7 +62,7 @@ public class TestWebRuleSet { > > =A0 =A0 =A0 =A0 WebXml webXml =3D new WebXml(); > > - =A0 =A0 =A0 =A0assertTrue(parse(webXml, "web-fragment-1ordering.xml", t= rue)); > + =A0 =A0 =A0 =A0parse(webXml, "web-fragment-1ordering.xml", true, true); > =A0 =A0 =A0 =A0 assertEquals(1, webXml.getBeforeOrdering().size()); > =A0 =A0 =A0 =A0 assertTrue(webXml.getBeforeOrdering().contains("bar")); > =A0 =A0 } > @@ -70,7 +70,7 @@ public class TestWebRuleSet { > > =A0 =A0 @Test > =A0 =A0 public void testMultipleOrderingInWebFragmentXml() throws Excepti= on { > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2ordering.= xml", true)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2ordering.xml", true, = false); > =A0 =A0 } > > > @@ -79,7 +79,7 @@ public class TestWebRuleSet { > > =A0 =A0 =A0 =A0 WebXml webXml =3D new WebXml(); > > - =A0 =A0 =A0 =A0assertTrue(parse(webXml, "web-1ordering.xml", false)); > + =A0 =A0 =A0 =A0parse(webXml, "web-1ordering.xml", false, true); > =A0 =A0 =A0 =A0 assertEquals(1, webXml.getAbsoluteOrdering().size()); > =A0 =A0 =A0 =A0 assertTrue(webXml.getAbsoluteOrdering().contains("bar")); > =A0 =A0 } > @@ -87,34 +87,34 @@ public class TestWebRuleSet { > > =A0 =A0 @Test > =A0 =A0 public void testMultipleOrderingInWebXml() throws Exception { > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-2ordering.xml", fal= se)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-2ordering.xml", false, false); > =A0 =A0 } > > > =A0 =A0 @Test > =A0 =A0 public void testRecycle() throws Exception { > =A0 =A0 =A0 =A0 // Name > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2name.xml"= , true)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-fragment-1name.xml",= true)); > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2name.xml"= , true)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-fragment-1name.xml",= true)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2name.xml", true, fals= e); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-1name.xml", true, true= ); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2name.xml", true, fals= e); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-1name.xml", true, true= ); > > =A0 =A0 =A0 =A0 // Relative ordering > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2ordering.= xml", true)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-fragment-1ordering.x= ml", true)); > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-fragment-2ordering.= xml", true)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-fragment-1ordering.x= ml", true)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2ordering.xml", true, = false); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-1ordering.xml", true, = true); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-2ordering.xml", true, = false); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-fragment-1ordering.xml", true, = true); > > =A0 =A0 =A0 =A0 // Absolute ordering > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-2ordering.xml", fal= se)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-1ordering.xml", fals= e)); > - =A0 =A0 =A0 =A0assertFalse(parse(new WebXml(), "web-2ordering.xml", fal= se)); > - =A0 =A0 =A0 =A0assertTrue(parse(new WebXml(), "web-1ordering.xml", fals= e)); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-2ordering.xml", false, false); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-1ordering.xml", false, true); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-2ordering.xml", false, false); > + =A0 =A0 =A0 =A0parse(new WebXml(), "web-1ordering.xml", false, true); > =A0} > > > - =A0 =A0private synchronized boolean parse(WebXml webXml, String target, > - =A0 =A0 =A0 =A0 =A0 =A0boolean fragment) { > + =A0 =A0private synchronized void parse(WebXml webXml, String target, > + =A0 =A0 =A0 =A0 =A0 =A0boolean fragment, boolean expected) { > > =A0 =A0 =A0 =A0 Digester d; > =A0 =A0 =A0 =A0 if (fragment) { > @@ -135,9 +135,17 @@ public class TestWebRuleSet { > =A0 =A0 =A0 =A0 try { > =A0 =A0 =A0 =A0 =A0 =A0 d.parse(is); > =A0 =A0 =A0 =A0 } catch (Exception e) { > + =A0 =A0 =A0 =A0 =A0 =A0if (expected) { > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0// Didn't expect an exception > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0e.printStackTrace(); > + =A0 =A0 =A0 =A0 =A0 =A0} > =A0 =A0 =A0 =A0 =A0 =A0 result =3D false; > =A0 =A0 =A0 =A0 } > > - =A0 =A0 =A0 =A0return result; > + =A0 =A0 =A0 =A0if (expected) { > + =A0 =A0 =A0 =A0 =A0 =A0assertTrue(result); > + =A0 =A0 =A0 =A0} else { > + =A0 =A0 =A0 =A0 =A0 =A0assertFalse(result); > + =A0 =A0 =A0 =A0} > =A0 =A0 } > =A0} > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org