Return-Path: X-Original-To: apmail-tomcat-dev-archive@www.apache.org Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B6C5180A9 for ; Thu, 18 Aug 2011 04:41:22 +0000 (UTC) Received: (qmail 61569 invoked by uid 500); 18 Aug 2011 04:41:21 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 60687 invoked by uid 500); 18 Aug 2011 04:41:08 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 60674 invoked by uid 99); 18 Aug 2011 04:41:00 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2011 04:41:00 +0000 Received: from localhost (HELO fc14x86v0.jboss.hr) (127.0.0.1) (smtp-auth username mturk, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Aug 2011 04:40:59 +0000 Message-ID: <4E4C97D8.4090005@apache.org> Date: Thu, 18 Aug 2011 06:40:56 +0200 From: Mladen Turk User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r1158991 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml References: <20110818015431.CDC482388A33@eris.apache.org> In-Reply-To: <20110818015431.CDC482388A33@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/18/2011 03:54 AM, timw@apache.org wrote: > Author: timw > Date: Thu Aug 18 01:54:31 2011 > New Revision: 1158991 > > URL: http://svn.apache.org/viewvc?rev=1158991&view=rev > Log: > Use the DLL handle to make the shared memory file name used by the ISAPI Redirector unique for each DLL - the redirector supports multiple instances per website, and without this multiple redirectors could access the same shared memory file, corrupting the contents (evident when LB workers are used on IIS 7). > Hmm, isn't that actually disabling the shared memory purpose? There is no point to have shared memory if it can't be shared across the processes. Your change makes no sense to me, cause now the shared memory is unique to each worker process which can be easily solved by not using the shared memory at all. IMHO if IIS7 corrupts the shared memory, we should find a way to better synchronize the access to it from multiple processes instead just making it unique to each process. Regards -- ^TM --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org