Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 33131 invoked from network); 15 Sep 2010 05:23:25 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Sep 2010 05:23:25 -0000 Received: (qmail 89736 invoked by uid 500); 15 Sep 2010 05:23:24 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 89384 invoked by uid 500); 15 Sep 2010 05:23:22 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 89373 invoked by uid 99); 15 Sep 2010 05:23:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 05:23:20 +0000 X-ASF-Spam-Status: No, hits=-1996.4 required=10.0 tests=ALL_TRUSTED,FS_REPLICA,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 15 Sep 2010 05:23:20 +0000 Received: (qmail 33089 invoked by uid 99); 15 Sep 2010 05:23:00 -0000 Received: from localhost.apache.org (HELO mail-wy0-f173.google.com) (127.0.0.1) (smtp-auth username kfujino, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Sep 2010 05:23:00 +0000 Received: by wyb39 with SMTP id 39so10411772wyb.18 for ; Tue, 14 Sep 2010 22:22:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.1.20 with SMTP id 20mr4781870wec.66.1284528177987; Tue, 14 Sep 2010 22:22:57 -0700 (PDT) Received: by 10.216.243.14 with HTTP; Tue, 14 Sep 2010 22:22:57 -0700 (PDT) In-Reply-To: References: <20100914074934.143C623889E0@eris.apache.org> Date: Wed, 15 Sep 2010 14:22:57 +0900 Message-ID: Subject: Re: svn commit: r996778 - in /tomcat/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java webapps/docs/changelog.xml From: Keiichi Fujino To: Tomcat Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable >> >> URL: http://svn.apache.org/viewvc?rev=3D996778&view=3Drev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=3D49924 >> When non-primary node changes into a primary node, make sure isPrimarySe= ssion is changed to true. >> >> Modified: >> =A0 =A0tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.ja= va >> =A0 =A0tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplic= atedMap.java > > I may be wrong, but the change to this file appears to be nothing to > do with the SVN log message. > > Looks like a separate change was accidentally committed. > When a primary node is stopped, it becomes the following. =3D=3D=3D=3D=3D=3D sessionA(Primary node=3DTomcat1, Backup node=3DTomcat2, Proxy node=3DTomcat= 3) Tomcat1 DeltaSession#isPrimarySession:true Tomcat2 DeltaSession#isPrimarySession:false Tomcat3 is Proxy. Tomcat1 stopped. sessionA(Primary node=3DTomcat2, Backup node=3DTomcat3, Proxy node=3Dno nod= e) Tomcat2 DeltaSession#isPrimarySession:false Tomcat3 DeltaSession#isPrimarySession:false =3D=3D=3D=3D=3D=3D DeltaSession#isPrimarySession is false though the node changes from the backup into primary. We should change isPrimarySession to true. I did the following corrections to this problem. Because after the backup node is promoted to a primary node, MapOwner#objectMadePrimay is called, I added "setPrimarySession(true)" to MapOwner(BackupManager)#objectMadePrimay method. As a result, DeltaSession#isPrimarySession of Tomcat2 is changed to true. Additionally, I added "getMapOwner().objectMadePrimay(key, entry.getValue());" to AbstractReplicatedMap#get so that when we get a non-primary session, isPrimarySession change to true. I think that isPrimarySession is changed to true in this rev. Where of this rev is the problem? --=20 Keiichi.Fujino --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org