Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 64691 invoked from network); 23 Sep 2010 14:30:07 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 23 Sep 2010 14:30:07 -0000 Received: (qmail 38135 invoked by uid 500); 23 Sep 2010 14:30:06 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 37825 invoked by uid 500); 23 Sep 2010 14:30:03 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 37815 invoked by uid 99); 23 Sep 2010 14:30:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Sep 2010 14:30:02 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Sep 2010 14:30:01 +0000 Received: from thor.apache.org (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o8NETf3n003090 for ; Thu, 23 Sep 2010 14:29:41 GMT Received: (from daemon@localhost) by thor.apache.org (8.13.8+Sun/8.13.8/Submit) id o8NETfhP003089; Thu, 23 Sep 2010 10:29:41 -0400 (EDT) Date: Thu, 23 Sep 2010 10:29:41 -0400 (EDT) Message-Id: <201009231429.o8NETfhP003089@thor.apache.org> From: bugzilla@apache.org To: dev@tomcat.apache.org Subject: DO NOT REPLY [Bug 49986] Double-check locking. Possible data-race in JspServletWrapper X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Tomcat 6 X-Bugzilla-Component: Jasper X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: sergeyvorobyev@google.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dev@tomcat.apache.org X-Bugzilla-Target-Milestone: default X-Bugzilla-Changed-Fields: In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 https://issues.apache.org/bugzilla/show_bug.cgi?id=49986 --- Comment #2 from Sergey Vorobyev 2010-09-23 10:29:38 EDT --- (In reply to comment #1) > Looks like a problem to me if the class can be called from multiple threads. > If not, then why have any synch. blocks at all? It's called from multiple threads. Stack trace: Thread 28 #0 org/apache/jasper/servlet/JspServletWrapper.getServlet JspServletWrapper.java:166 #1 org/apache/jasper/servlet/JspServletWrapper.service JspServletWrapper.java:329 #2 org/apache/jasper/servlet/JspServlet.serviceJspFile JspServlet.java:313 #3 org/apache/jasper/servlet/JspServlet.service JspServlet.java:260 #4 javax/servlet/http/HttpServlet.service HttpServlet.java:717 #5 org/apache/catalina/core/ApplicationFilterChain.internalDoFilter ApplicationFilterChain.java:290 #6 org/apache/catalina/core/ApplicationFilterChain.doFilter ApplicationFilterChain.java:206 #7 org/apache/catalina/core/StandardWrapperValve.invoke StandardWrapperValve.java:233 #8 org/apache/catalina/core/StandardContextValve.invoke StandardContextValve.java:191 #9 org/apache/catalina/authenticator/AuthenticatorBase.invoke AuthenticatorBase.java:470 #10 org/apache/catalina/core/StandardHostValve.invoke StandardHostValve.java:127 #11 org/apache/catalina/valves/ErrorReportValve.invoke ErrorReportValve.java:102 Thread 25 #0 org/apache/jasper/servlet/JspServletWrapper.getServlet JspServletWrapper.java:133 #1 org/apache/jasper/servlet/JspServletWrapper.service JspServletWrapper.java:329 #2 org/apache/jasper/servlet/JspServlet.serviceJspFile JspServlet.java:313 #3 org/apache/jasper/servlet/JspServlet.service JspServlet.java:260 #4 javax/servlet/http/HttpServlet.service HttpServlet.java:717 #5 org/apache/catalina/core/ApplicationFilterChain.internalDoFilter ApplicationFilterChain.java:290 #6 org/apache/catalina/core/ApplicationFilterChain.doFilter ApplicationFilterChain.java:206 #7 org/apache/catalina/core/StandardWrapperValve.invoke StandardWrapperValve.java:233 #8 org/apache/catalina/core/StandardContextValve.invoke StandardContextValve.java:191 #9 org/apache/catalina/authenticator/AuthenticatorBase.invoke AuthenticatorBase.java:470 > The servletClassLastModifiedTime also looks to be used in a similar way; that > is a long so could potentially an invalid value could be read. Exactly! Thank you for point public void setServletClassLastModifiedTime(long lastModified) { if (this.servletClassLastModifiedTime < lastModified) { synchronized (this) { if (this.servletClassLastModifiedTime < lastModified) { this.servletClassLastModifiedTime = lastModified; reload = true; } } } } -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org